Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-scheduler: LoadAware scheduling support percentile usage #882

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Dec 14, 2022

Signed-off-by: Joseph joseph.t.lee@outlook.com

Ⅰ. Describe what this PR does

  • The LoadAware scheduling plugin support filter/score with aggregated usages such as P99/P95.
  • Not enabled by default. Users can set AggregatedUsages via the annotation of Node or args of plugin.
  • If the koordlet have not report the aggregated usages, koord-scheduler will use the estimated result as current usage to balance.

Ⅱ. Does this pull request fix one issue?

fix #856

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@eahydra
Copy link
Member Author

eahydra commented Dec 14, 2022

/milestone v1.1

@koordinator-bot koordinator-bot bot added this to the v1.1 milestone Dec 14, 2022
@eahydra eahydra force-pushed the loadaware_support_aggregated_usage branch 2 times, most recently from 1d25e45 to 0670ddc Compare December 14, 2022 14:33
@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Base: 66.90% // Head: 66.89% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (34cf375) compared to base (c43b4db).
Patch coverage: 68.08% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #882      +/-   ##
==========================================
- Coverage   66.90%   66.89%   -0.02%     
==========================================
  Files         234      234              
  Lines       26874    26973      +99     
==========================================
+ Hits        17981    18044      +63     
- Misses       7616     7651      +35     
- Partials     1277     1278       +1     
Flag Coverage Δ
unittests 66.89% <68.08%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/util/pod_resources_utils.go 52.87% <0.00%> (-5.36%) ⬇️
pkg/scheduler/plugins/loadaware/helper.go 66.96% <57.74%> (-19.32%) ⬇️
pkg/scheduler/plugins/loadaware/load_aware.go 77.09% <88.70%> (+3.39%) ⬆️
pkg/koordlet/runtimehooks/reconciler/reconciler.go 65.88% <0.00%> (-1.18%) ⬇️
pkg/util/httputil/reverseproxy.go 85.10% <0.00%> (+0.79%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eahydra eahydra force-pushed the loadaware_support_aggregated_usage branch 2 times, most recently from 43f423b to 6b94e38 Compare December 15, 2022 08:15
@eahydra eahydra force-pushed the loadaware_support_aggregated_usage branch from 6b94e38 to f362ccd Compare December 22, 2022 04:42
@saintube
Copy link
Member

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Dec 22, 2022
@eahydra eahydra force-pushed the loadaware_support_aggregated_usage branch from f362ccd to 405d391 Compare December 23, 2022 05:28
@koordinator-bot koordinator-bot bot removed the lgtm label Dec 23, 2022
@eahydra eahydra force-pushed the loadaware_support_aggregated_usage branch from 405d391 to 04327a9 Compare December 23, 2022 06:20
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@eahydra eahydra force-pushed the loadaware_support_aggregated_usage branch from 04327a9 to 34cf375 Compare December 23, 2022 06:58
@eahydra
Copy link
Member Author

eahydra commented Dec 23, 2022

optimize filter implement. cc @saintube

@ZiMengSheng
Copy link
Contributor

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Dec 26, 2022
Copy link
Contributor

@buptcozy buptcozy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@buptcozy buptcozy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Member

@FillZpp FillZpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: buptcozy, FillZpp, ZiMengSheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit a9eea83 into koordinator-sh:main Dec 26, 2022
lucming pushed a commit to lucming/koordinator that referenced this pull request Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[proposal] more detailed data is need in NodeMetric for scheduler/descheduler
5 participants