-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koordlet: release feature gates config #887
koordlet: release feature gates config #887
Conversation
/assign @FillZpp @jasonliu747 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI failed, PTAL.
Codecov ReportBase: 66.49% // Head: 66.49% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #887 +/- ##
=======================================
Coverage 66.49% 66.49%
=======================================
Files 233 233
Lines 26757 26752 -5
=======================================
- Hits 17791 17789 -2
+ Misses 7707 7706 -1
+ Partials 1259 1257 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/milestone v1.1 |
Signed-off-by: 佑祎 <zzw261520@alibaba-inc.com>
ping @FillZpp @eahydra @jasonliu747 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eahydra, FillZpp, jasonliu747 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: 佑祎 <zzw261520@alibaba-inc.com>
Signed-off-by: 佑祎 zzw261520@alibaba-inc.com
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test