Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: release feature gates config #887

Merged
merged 1 commit into from
Dec 23, 2022
Merged

koordlet: release feature gates config #887

merged 1 commit into from
Dec 23, 2022

Conversation

zwzhang0107
Copy link
Contributor

Signed-off-by: 佑祎 zzw261520@alibaba-inc.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@zwzhang0107
Copy link
Contributor Author

/assign @FillZpp @jasonliu747

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failed, PTAL.

@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Base: 66.49% // Head: 66.49% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (184f5c0) compared to base (7af9f66).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #887   +/-   ##
=======================================
  Coverage   66.49%   66.49%           
=======================================
  Files         233      233           
  Lines       26757    26752    -5     
=======================================
- Hits        17791    17789    -2     
+ Misses       7707     7706    -1     
+ Partials     1259     1257    -2     
Flag Coverage Δ
unittests 66.49% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/runtimehooks/config.go 100.00% <100.00%> (ø)
pkg/koordlet/runtimehooks/runtimehooks.go 70.31% <100.00%> (+4.68%) ⬆️
pkg/koordlet/util/resourceexecutor/executor.go 37.19% <0.00%> (-2.48%) ⬇️
pkg/slo-controller/config/config.go 92.75% <0.00%> (-0.31%) ⬇️
pkg/koordlet/util/pod.go 53.75% <0.00%> (ø)
pkg/koordlet/util/node.go 45.00% <0.00%> (ø)
pkg/util/httputil/reverseproxy.go 85.10% <0.00%> (+0.79%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot koordinator-bot bot removed the lgtm label Dec 20, 2022
@FillZpp
Copy link
Member

FillZpp commented Dec 20, 2022

/milestone v1.1

@koordinator-bot koordinator-bot bot added this to the v1.1 milestone Dec 20, 2022
Signed-off-by: 佑祎 <zzw261520@alibaba-inc.com>
@zwzhang0107
Copy link
Contributor Author

ping @FillZpp @eahydra @jasonliu747

Copy link
Member

@FillZpp FillZpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Dec 23, 2022
@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra, FillZpp, jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit c43b4db into koordinator-sh:main Dec 23, 2022
lucming pushed a commit to lucming/koordinator that referenced this pull request Feb 8, 2023
Signed-off-by: 佑祎 <zzw261520@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants