Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: fix updateBatch method of executor and update some comments in util #890

Merged

Conversation

LeoLiuYan
Copy link
Contributor

Signed-off-by: LeoLiuYan 929908264@qq.com

Ⅰ. Describe what this PR does

As the title said, fix print info log when batch update cgroup's values and update some missing comments in util.

Ⅱ. Does this pull request fix one issue?

None

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: LeoLiuYan <929908264@qq.com>
@LeoLiuYan LeoLiuYan changed the title koordlat: fix updateBatch method of executor and update some comments in util koordlet: fix updateBatch method of executor and update some comments in util Dec 18, 2022
@codecov
Copy link

codecov bot commented Dec 18, 2022

Codecov Report

Base: 66.49% // Head: 66.47% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (eb7ab41) compared to base (7af9f66).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #890      +/-   ##
==========================================
- Coverage   66.49%   66.47%   -0.02%     
==========================================
  Files         233      233              
  Lines       26757    26757              
==========================================
- Hits        17791    17788       -3     
- Misses       7707     7710       +3     
  Partials     1259     1259              
Flag Coverage Δ
unittests 66.47% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/util/node.go 45.00% <ø> (ø)
pkg/koordlet/util/pod.go 53.75% <ø> (ø)
pkg/koordlet/resmanager/cpu_suppress.go 68.86% <100.00%> (ø)
pkg/koordlet/util/resourceexecutor/executor.go 37.19% <100.00%> (-2.48%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zwzhang0107
Copy link
Contributor

/lgtm

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 08bb486 into koordinator-sh:main Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants