Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

koordlet: Reduce update NodeResourceTopology frequency #893

Merged
merged 8 commits into from
Dec 29, 2022
Merged

koordlet: Reduce update NodeResourceTopology frequency #893

merged 8 commits into from
Dec 29, 2022

Conversation

Re-Grh
Copy link
Contributor

@Re-Grh Re-Grh commented Dec 19, 2022

Signed-off-by: Mew2 1271013391@qq.com

Ⅰ. Describe what this PR does

Refactor the nodeTopoInformer module to reduce the overhead of reporting NodeResourceTopology.

Ⅱ. Does this pull request fix one issue?

fixes #817

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Dec 19, 2022 •
edited

Codecov Report

Base: 66.65% // Head: 66.64% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (283849a) compared to base (580b447).
Patch coverage: 74.41% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #893      +/-   ##
==========================================
- Coverage   66.65%   66.64%   -0.02%     
==========================================
  Files         238      238              
  Lines       27682    27716      +34     
==========================================
+ Hits        18452    18470      +18     
- Misses       7963     7982      +19     
+ Partials     1267     1264       -3
Flag Coverage Δ
unittests 66.64% <74.41%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dlet/statesinformer/states_noderesourcetopology.go 64.55% <74.41%> (+1.29%) ⬆️
pkg/koordlet/runtimehooks/reconciler/reconciler.go 61.76% <0.00%> (-4.12%) ⬇️
pkg/util/httputil/reverseproxy.go 84.84% <0.00%> (-0.27%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eahydra eahydra changed the title koordlet: Reduce update and report NodeResourceTopology frequency koordlet: Reduce update NodeResourceTopology frequency Dec 19, 2022
eahydra
eahydra reviewed Dec 19, 2022
View reviewed changes
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some unit tests.

pkg/koordlet/statesinformer/states_noderesourcetopology.go Outdated Show resolved Hide resolved
pkg/util/resource.go Outdated Show resolved Hide resolved
@FillZpp
Copy link
Member

FillZpp commented Dec 20, 2022

/milestone v1.2

@koordinator-bot koordinator-bot bot added this to the v1.2 milestone Dec 20, 2022
@koordinator-bot koordinator-bot bot added size/L and removed size/M labels Dec 26, 2022
@Re-Grh Re-Grh requested review from saintube and removed request for FillZpp December 28, 2022 10:33
@Re-Grh
issue-893
c741b34 
Signed-off-by: Mew2 <1271013391@qq.com>
@Re-Grh
issue-893
7156bcc 
Signed-off-by: Mew2 <1271013391@qq.com>
@Re-Grh
issue-893
0a780fb 
Signed-off-by: Mew2 <1271013391@qq.com>
@Re-Grh
issue-893
9278746 
Signed-off-by: Mew2 <1271013391@qq.com>
@Re-Grh
issue-893-f
284a879 
Signed-off-by: Mew2 <1271013391@qq.com>
@Re-Grh
issue-893-fix
85f762e 
Signed-off-by: Mew2 <1271013391@qq.com>
@Re-Grh
issue-893-f
1e2d1ea 
Signed-off-by: Mew2 <1271013391@qq.com>
@Re-Grh Re-Grh requested a review from saintube December 29, 2022 03:29
saintube
saintube approved these changes Dec 29, 2022
View reviewed changes
Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Dec 29, 2022
@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saintube

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 20b05af into koordinator-sh:main Dec 29, 2022
FillZpp pushed a commit that referenced this pull request Jan 16, 2023
@Re-Grh @FillZpp
koordlet: Reduce update NodeResourceTopology frequency (#893)
27ce3ad 
Signed-off-by: Mew2 <1271013391@qq.com>
lucming pushed a commit to lucming/koordinator that referenced this pull request Feb 8, 2023
@Re-Grh @lucming
koordlet: Reduce update NodeResourceTopology frequency (koordinator-s…
6f0d447 
…h#893)

Signed-off-by: Mew2 <1271013391@qq.com>
@wangxiaoq wangxiaoq mentioned this pull request Apr 14, 2023
Closed
@saintube saintube mentioned this pull request Aug 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eahydra eahydra eahydra left review comments

@jasonliu747 jasonliu747 jasonliu747 left review comments

@zwzhang0107 zwzhang0107 zwzhang0107 left review comments

@saintube saintube saintube approved these changes

Assignees

@saintube saintube

Labels
approved lgtm size/L
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

[BUG] koordlet frequently Gets and Updates NodeResourceTopology
6 participants
@Re-Grh @FillZpp @eahydra @saintube @jasonliu747 @zwzhang0107