Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Koordlet: Feat add more metrics for cpu burst and suppress #905

Conversation

LeoLiuYan
Copy link
Contributor

Signed-off-by: LeoLiuYan 929908264@qq.com

Ⅰ. Describe what this PR does

Add more prometheus metrics:

  • common.go: node_used_cpu_cores
  • cpu_burst.go: be_suppress_cpu_cores and be_suppress_ls_used_cpu_cores
  • cpu_suppress.go: ls_pod_cfs_burst_cpu_cores and ls_pod_cfs_burst_quota

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@LeoLiuYan LeoLiuYan force-pushed the feat/add_more_metrics_for_cpu_burst_and_suppress branch from cad87c9 to e09c3c3 Compare December 27, 2022 07:35
@codecov
Copy link

codecov bot commented Dec 27, 2022

Codecov Report

Base: 66.63% // Head: 66.66% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (934b69d) compared to base (20b05af).
Patch coverage: 65.95% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #905      +/-   ##
==========================================
+ Coverage   66.63%   66.66%   +0.03%     
==========================================
  Files         238      240       +2     
  Lines       27716    27759      +43     
==========================================
+ Hits        18468    18505      +37     
- Misses       7980     7983       +3     
- Partials     1268     1271       +3     
Flag Coverage Δ
unittests 66.66% <65.95%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/metricsadvisor/collector.go 43.79% <0.00%> (-0.12%) ⬇️
pkg/koordlet/metrics/cpu_suppress.go 53.84% <53.84%> (ø)
pkg/koordlet/metrics/cpu_burst.go 60.86% <60.86%> (ø)
pkg/koordlet/metrics/common.go 67.85% <100.00%> (-1.11%) ⬇️
pkg/koordlet/metrics/metrics.go 88.46% <100.00%> (+0.96%) ⬆️
pkg/koordlet/resmanager/cpu_burst.go 73.74% <100.00%> (+0.24%) ⬆️
pkg/koordlet/resmanager/cpu_suppress.go 68.88% <100.00%> (+0.06%) ⬆️
pkg/util/httputil/reverseproxy.go 85.10% <0.00%> (+0.79%) ⬆️
pkg/koordlet/runtimehooks/reconciler/reconciler.go 65.88% <0.00%> (+4.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@LeoLiuYan
Copy link
Contributor Author

@saintube @zwzhang0107 Please review again when you are free.

pkg/koordlet/metrics/cpu_burst.go Outdated Show resolved Hide resolved
pkg/koordlet/resmanager/cpu_burst.go Outdated Show resolved Hide resolved
pkg/koordlet/metrics/cpu_suppress.go Show resolved Hide resolved
@LeoLiuYan LeoLiuYan force-pushed the feat/add_more_metrics_for_cpu_burst_and_suppress branch 2 times, most recently from 23ef3ec to 3298ec5 Compare December 28, 2022 07:05
@LeoLiuYan LeoLiuYan force-pushed the feat/add_more_metrics_for_cpu_burst_and_suppress branch from 3298ec5 to a52b1d8 Compare December 28, 2022 08:07
@LeoLiuYan LeoLiuYan force-pushed the feat/add_more_metrics_for_cpu_burst_and_suppress branch from a52b1d8 to f4c96bf Compare December 28, 2022 09:10
@LeoLiuYan LeoLiuYan requested review from saintube and removed request for zwzhang0107 December 29, 2022 01:56
@LeoLiuYan LeoLiuYan force-pushed the feat/add_more_metrics_for_cpu_burst_and_suppress branch from f4c96bf to 25e4191 Compare December 29, 2022 03:32
Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Signed-off-by: LeoLiuYan <929908264@qq.com>
@LeoLiuYan LeoLiuYan force-pushed the feat/add_more_metrics_for_cpu_burst_and_suppress branch from 25e4191 to 934b69d Compare December 29, 2022 07:14
@koordinator-bot koordinator-bot bot removed the lgtm label Dec 29, 2022
@LeoLiuYan
Copy link
Contributor Author

LeoLiuYan commented Dec 29, 2022

@saintube Please add the /lgtm comment again as this PR has rebased the main branch.

Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Dec 29, 2022
@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saintube

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 52c3fa8 into koordinator-sh:main Dec 29, 2022
FillZpp pushed a commit that referenced this pull request Jan 16, 2023
lucming pushed a commit to lucming/koordinator that referenced this pull request Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants