-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koordlet: support cpu eviction in cpuset supress mode with cpu static policy #914
Conversation
Codecov ReportBase: 66.63% // Head: 66.52% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #914 +/- ##
==========================================
- Coverage 66.63% 66.52% -0.12%
==========================================
Files 240 240
Lines 27769 27782 +13
==========================================
- Hits 18505 18481 -24
- Misses 7992 8035 +43
+ Partials 1272 1266 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
/lgtm |
Just clean the commit, remove the useless 'Merge' commit. Please re-review it, thanks. @zwzhang0107 |
related issue: #546 |
Signed-off-by: Wang Xiaoqiang <wangxiaoqiang@qiyi.com>
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zwzhang0107 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
… policy (#914) Signed-off-by: Wang Xiaoqiang <wangxiaoqiang@qiyi.com>
… policy (koordinator-sh#914) Signed-off-by: Wang Xiaoqiang <wangxiaoqiang@qiyi.com>
Ⅰ. Describe what this PR does
Cpu eviction does not work for cpuset suppress mode with cpu manager static policy, this pr fix it.
Ⅱ. Does this pull request fix one issue?
fix #871
Ⅲ. Describe how to verify it
Configure kubelet with cpuManagerPolicy: static
Configure koordinator's resource-threshold-config with:
Create a be pod: pod1 on a K8s node: node1
Increase the node1's cpu usage until pod1 is evicted
Ⅳ. Special notes for reviews
V. Checklist
make test