Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use buildx to replace gorelaser to release image #919

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

jasonliu747
Copy link
Member

Signed-off-by: Jason Liu jasonliu747@gmail.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Base: 66.66% // Head: 66.62% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (57c5425) compared to base (59b7e90).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #919      +/-   ##
==========================================
- Coverage   66.66%   66.62%   -0.05%     
==========================================
  Files         240      243       +3     
  Lines       27769    28147     +378     
==========================================
+ Hits        18513    18752     +239     
- Misses       7987     8109     +122     
- Partials     1269     1286      +17     
Flag Coverage Δ
unittests 66.62% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/util/node.go 11.23% <0.00%> (-30.44%) ⬇️
.../webhook/pod/validating/request_limit_validator.go 71.84% <0.00%> (-23.20%) ⬇️
pkg/koordlet/audit/event_logger.go 65.53% <0.00%> (-3.98%) ⬇️
pkg/scheduler/plugins/reservation/hook.go 77.00% <0.00%> (-2.17%) ⬇️
pkg/koordlet/runtimehooks/reconciler/reconciler.go 65.88% <0.00%> (-1.18%) ⬇️
...dlet/statesinformer/states_noderesourcetopology.go 63.76% <0.00%> (-0.79%) ⬇️
pkg/util/httputil/reverseproxy.go 84.30% <0.00%> (-0.54%) ⬇️
...duler/plugins/elasticquota/quota_overuse_revoke.go 70.05% <0.00%> (-0.53%) ⬇️
pkg/scheduler/plugins/reservation/plugin.go 80.43% <0.00%> (-0.40%) ⬇️
pkg/descheduler/evictions/evictions.go 90.81% <0.00%> (-0.28%) ⬇️
... and 25 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jasonliu747
Copy link
Member Author

/hold

Signed-off-by: Jason Liu <jasonliu747@gmail.com>
@jasonliu747
Copy link
Member Author

/unhold

Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: eahydra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 5f78591 into koordinator-sh:main Jan 11, 2023
FillZpp pushed a commit that referenced this pull request Jan 16, 2023
Signed-off-by: Jason Liu <jasonliu747@gmail.com>
lucming pushed a commit to lucming/koordinator that referenced this pull request Feb 8, 2023
)

Signed-off-by: Jason Liu <jasonliu747@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants