Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-scheduler: protect reserve pod from being preempted #920

Conversation

KunWuLuan
Copy link
Contributor

Now reserve pod can be preempt by real pods, but these reserve pods won't be deleted by preemptor because they don't exist on apiserver. It will cause problem when a real pod try to preempt a reserve pod, the real pod will never find the reserve pod being terminated.

@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Base: 66.66% // Head: 66.48% // Decreases project coverage by -0.17% ⚠️

Coverage data is based on head (9e102fb) compared to base (59b7e90).
Patch coverage: 71.42% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #920      +/-   ##
==========================================
- Coverage   66.66%   66.48%   -0.18%     
==========================================
  Files         240      241       +1     
  Lines       27769    27946     +177     
==========================================
+ Hits        18513    18581      +68     
- Misses       7987     8087     +100     
- Partials     1269     1278       +9     
Flag Coverage Δ
unittests 66.48% <71.42%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/scheduler/plugins/reservation/plugin.go 80.43% <71.42%> (-0.40%) ⬇️
pkg/koordlet/util/node.go 11.23% <0.00%> (-30.44%) ⬇️
.../webhook/pod/validating/request_limit_validator.go 71.84% <0.00%> (-23.20%) ⬇️
pkg/koordlet/audit/event_logger.go 65.53% <0.00%> (-3.98%) ⬇️
pkg/koordlet/runtimehooks/reconciler/reconciler.go 65.88% <0.00%> (-1.18%) ⬇️
...er/framework/plugins/loadaware/utilization_util.go 88.35% <0.00%> (-1.13%) ⬇️
...duler/plugins/elasticquota/quota_overuse_revoke.go 70.05% <0.00%> (-0.53%) ⬇️
pkg/descheduler/evictions/evictions.go 90.81% <0.00%> (-0.28%) ⬇️
pkg/koordlet/audit/config.go 100.00% <0.00%> (ø)
pkg/koordlet/metrics/common.go 67.85% <0.00%> (ø)
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eahydra eahydra changed the title protect reserve pod from being preempted koord-scheduler: protect reserve pod from being preempted Jan 4, 2023
@eahydra
Copy link
Member

eahydra commented Jan 4, 2023

@saintube PTAL

@KunWuLuan KunWuLuan force-pushed the protect-reserve-pod-from-being-preempted branch from b4bbaa2 to cad7c4b Compare January 4, 2023 02:37
@KunWuLuan KunWuLuan force-pushed the protect-reserve-pod-from-being-preempted branch 6 times, most recently from 624e647 to 4773d00 Compare January 9, 2023 08:33
Signed-off-by: KunWuLuan <kunwuluan@gmail.com>
@KunWuLuan KunWuLuan force-pushed the protect-reserve-pod-from-being-preempted branch from 4773d00 to 9e102fb Compare January 10, 2023 02:34
Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 4ba54c6 into koordinator-sh:main Jan 10, 2023
FillZpp pushed a commit that referenced this pull request Jan 16, 2023
Signed-off-by: KunWuLuan <kunwuluan@gmail.com>
lucming pushed a commit to lucming/koordinator that referenced this pull request Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants