-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koord-scheduler: protect reserve pod from being preempted #920
koord-scheduler: protect reserve pod from being preempted #920
Conversation
Codecov ReportBase: 66.66% // Head: 66.48% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #920 +/- ##
==========================================
- Coverage 66.66% 66.48% -0.18%
==========================================
Files 240 241 +1
Lines 27769 27946 +177
==========================================
+ Hits 18513 18581 +68
- Misses 7987 8087 +100
- Partials 1269 1278 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@saintube PTAL |
b4bbaa2
to
cad7c4b
Compare
624e647
to
4773d00
Compare
Signed-off-by: KunWuLuan <kunwuluan@gmail.com>
4773d00
to
9e102fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eahydra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: KunWuLuan <kunwuluan@gmail.com>
…r-sh#920) Signed-off-by: KunWuLuan <kunwuluan@gmail.com>
Now reserve pod can be preempt by real pods, but these reserve pods won't be deleted by preemptor because they don't exist on apiserver. It will cause problem when a real pod try to preempt a reserve pod, the real pod will never find the reserve pod being terminated.