Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-manager: Fix log print fmt and add an example for slo-controller-config #925

Conversation

LeoLiuYan
Copy link
Contributor

Signed-off-by: LeoLiuYan 929908264@qq.com

Ⅰ. Describe what this PR does

As the title says.

Ⅱ. Does this pull request fix one issue?

NONE.

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@LeoLiuYan LeoLiuYan changed the title koord-controller: Fix log print fmt and add an example for slo-controller-config koord-manager: Fix log print fmt and add an example for slo-controller-config Jan 4, 2023
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Base: 66.58% // Head: 66.58% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (b191d03) compared to base (bfaf129).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #925      +/-   ##
==========================================
- Coverage   66.58%   66.58%   -0.01%     
==========================================
  Files         240      240              
  Lines       27754    27754              
==========================================
- Hits        18481    18480       -1     
- Misses       8003     8004       +1     
  Partials     1270     1270              
Flag Coverage Δ
unittests 66.58% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/slo-controller/noderesource/noderesource.go 76.39% <100.00%> (ø)
pkg/util/httputil/reverseproxy.go 85.10% <0.00%> (-0.27%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

pkg/slo-controller/config/constants.go Outdated Show resolved Hide resolved
pkg/slo-controller/config/constants.go Outdated Show resolved Hide resolved
Signed-off-by: LeoLiuYan <929908264@qq.com>
@LeoLiuYan LeoLiuYan force-pushed the feat/add_examples_for_slo_config branch from e7919b9 to b191d03 Compare January 5, 2023 02:46
@saintube
Copy link
Member

saintube commented Jan 5, 2023

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 06bb2c5 into koordinator-sh:main Jan 5, 2023
FillZpp pushed a commit that referenced this pull request Jan 16, 2023
…r-config (#925)

Signed-off-by: LeoLiuYan <929908264@qq.com>
lucming pushed a commit to lucming/koordinator that referenced this pull request Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants