-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koord-manager: Fix log print fmt and add an example for slo-controller-config #925
koord-manager: Fix log print fmt and add an example for slo-controller-config #925
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Codecov ReportBase: 66.58% // Head: 66.58% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #925 +/- ##
==========================================
- Coverage 66.58% 66.58% -0.01%
==========================================
Files 240 240
Lines 27754 27754
==========================================
- Hits 18481 18480 -1
- Misses 8003 8004 +1
Partials 1270 1270
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ccdabf7
to
e7919b9
Compare
Signed-off-by: LeoLiuYan <929908264@qq.com>
e7919b9
to
b191d03
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jasonliu747 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…r-config (#925) Signed-off-by: LeoLiuYan <929908264@qq.com>
…r-config (koordinator-sh#925) Signed-off-by: LeoLiuYan <929908264@qq.com>
Signed-off-by: LeoLiuYan 929908264@qq.com
Ⅰ. Describe what this PR does
As the title says.
Ⅱ. Does this pull request fix one issue?
NONE.
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test