Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-descheduler: add evict event/metric for Pod during migration #932

Merged

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Jan 6, 2023

Signed-off-by: Joseph joseph.t.lee@outlook.com

Ⅰ. Describe what this PR does

  1. Add eviction event with reason/pluginName for Pod during migration.
  2. Update eviction metric after eviction

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@eahydra
Copy link
Member Author

eahydra commented Jan 6, 2023

/hold

@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Base: 66.42% // Head: 66.50% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (c688588) compared to base (3b88616).
Patch coverage: 88.63% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #932      +/-   ##
==========================================
+ Coverage   66.42%   66.50%   +0.07%     
==========================================
  Files         241      241              
  Lines       27908    27925      +17     
==========================================
+ Hits        18539    18571      +32     
+ Misses       8092     8079      -13     
+ Partials     1277     1275       -2     
Flag Coverage Δ
unittests 66.50% <88.63%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...kg/descheduler/controllers/migration/controller.go 62.15% <75.00%> (+0.35%) ⬆️
...er/framework/plugins/loadaware/utilization_util.go 88.35% <80.00%> (ø)
pkg/descheduler/evictions/evictions.go 90.81% <100.00%> (-0.28%) ⬇️
...duler/framework/plugins/loadaware/low_node_load.go 66.15% <100.00%> (+2.61%) ⬆️
pkg/descheduler/framework/runtime/framework.go 80.20% <100.00%> (+0.20%) ⬆️
pkg/util/httputil/reverseproxy.go 85.10% <0.00%> (+0.79%) ⬆️
pkg/scheduler/plugins/coscheduling/core/gang.go 75.39% <0.00%> (+0.94%) ⬆️
pkg/koordlet/runtimehooks/reconciler/reconciler.go 67.05% <0.00%> (+5.29%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eahydra eahydra force-pushed the add_evict_reason_in_event branch 2 times, most recently from 62bebef to 7704930 Compare January 6, 2023 11:01
@eahydra
Copy link
Member Author

eahydra commented Jan 6, 2023

/hold cancel
TBR

@eahydra eahydra force-pushed the add_evict_reason_in_event branch 4 times, most recently from c662221 to ea8a3c6 Compare January 9, 2023 06:27
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@zwzhang0107
Copy link
Contributor

/lgtm

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hormes
Copy link
Member

hormes commented Jan 9, 2023

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes, jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit e635b6c into koordinator-sh:main Jan 9, 2023
FillZpp pushed a commit that referenced this pull request Jan 16, 2023
)

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
lucming pushed a commit to lucming/koordinator that referenced this pull request Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants