Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: check key exist first before comparing node topo annotations #944

Merged
merged 1 commit into from
Jan 10, 2023
Merged

koordlet: check key exist first before comparing node topo annotations #944

merged 1 commit into from
Jan 10, 2023

Conversation

zwzhang0107
Copy link
Contributor

@zwzhang0107 zwzhang0107 commented Jan 10, 2023

Signed-off-by: 佑祎 zzw261520@alibaba-inc.com

Ⅰ. Describe what this PR does

some error logs exist, which should be omit.
image

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: 佑祎 <zzw261520@alibaba-inc.com>
@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Base: 66.56% // Head: 66.58% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (2a6824b) compared to base (4ba54c6).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #944      +/-   ##
==========================================
+ Coverage   66.56%   66.58%   +0.02%     
==========================================
  Files         243      243              
  Lines       28064    28099      +35     
==========================================
+ Hits        18680    18709      +29     
- Misses       8099     8106       +7     
+ Partials     1285     1284       -1     
Flag Coverage Δ
unittests 66.58% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dlet/statesinformer/states_noderesourcetopology.go 63.76% <100.00%> (-0.79%) ⬇️
pkg/koordlet/runtimehooks/reconciler/reconciler.go 61.76% <0.00%> (-4.12%) ⬇️
...kg/descheduler/controllers/migration/controller.go 62.06% <0.00%> (-0.09%) ⬇️
pkg/util/httputil/reverseproxy.go 85.10% <0.00%> (+0.79%) ⬆️
pkg/descheduler/controllers/migration/util/util.go 73.21% <0.00%> (+1.51%) ⬆️
pkg/descheduler/utils/sorter/helper.go 79.24% <0.00%> (+5.66%) ⬆️
pkg/descheduler/utils/sorter/pod.go 88.88% <0.00%> (+5.77%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@koordinator-bot koordinator-bot bot merged commit d3ada57 into koordinator-sh:main Jan 10, 2023
FillZpp pushed a commit that referenced this pull request Jan 16, 2023
#944)

Signed-off-by: 佑祎 <zzw261520@alibaba-inc.com>
lucming pushed a commit to lucming/koordinator that referenced this pull request Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants