-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koord-scheduler: additionally check parent's Quota if configured #945
Conversation
Codecov ReportBase: 66.58% // Head: 66.62% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #945 +/- ##
==========================================
+ Coverage 66.58% 66.62% +0.03%
==========================================
Files 243 243
Lines 28099 28147 +48
==========================================
+ Hits 18709 18752 +43
- Misses 8106 8109 +3
- Partials 1284 1286 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…imize the output log of PreFilter Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eahydra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com> Co-authored-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
…rdinator-sh#945) Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com> Co-authored-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
Signed-off-by: xulinfei.xlf xulinfei.xlf@alibaba-inc.com
Ⅰ. Describe what this PR does
ElasticQuotaPlugin
1、PreFilter will addtionally check the parent's usedQuota + pod's Request > parent's runtimeQuota if configured
2、The output of the PreFilter Result just print the map, which is unfriendly for users to read.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test