-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koord-manager: mv slo-controller config to api #949
koord-manager: mv slo-controller config to api #949
Conversation
Signed-off-by: 佑祎 <zzw261520@alibaba-inc.com>
Codecov ReportBase: 66.62% // Head: 66.98% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #949 +/- ##
==========================================
+ Coverage 66.62% 66.98% +0.36%
==========================================
Files 243 243
Lines 28147 28167 +20
==========================================
+ Hits 18752 18869 +117
+ Misses 8109 8013 -96
+ Partials 1286 1285 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Finally someone noticed that tiny TODO in this repo. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FillZpp, jasonliu747, saintube The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: 佑祎 <zzw261520@alibaba-inc.com>
Signed-off-by: 佑祎 <zzw261520@alibaba-inc.com>
Signed-off-by: 佑祎 zzw261520@alibaba-inc.com
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test