Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: fix batch resource plugin for empty label pods #952

Conversation

saintube
Copy link
Member

@saintube saintube commented Jan 12, 2023

Signed-off-by: saintube saintube@foxmail.com

Ⅰ. Describe what this PR does

Fix the batch resource plugin when the BE pod has no label or annotation.

Also, fix some log format errors.

Ⅱ. Does this pull request fix one issue?

Currently, the batch resource plugin aborts set cgroup resources when a BE pod has no label or annotation since it checks if both of them are non-nil.

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: saintube <saintube@foxmail.com>
@zwzhang0107
Copy link
Contributor

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zwzhang0107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zwzhang0107
Copy link
Contributor

/lgtm

@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Base: 67.00% // Head: 66.97% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (cc4b971) compared to base (2fcd601).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #952      +/-   ##
==========================================
- Coverage   67.00%   66.97%   -0.04%     
==========================================
  Files         243      243              
  Lines       28169    28166       -3     
==========================================
- Hits        18876    18865      -11     
- Misses       8006     8012       +6     
- Partials     1287     1289       +2     
Flag Coverage Δ
unittests 66.97% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...runtimehooks/hooks/batchresource/batch_resource.go 69.54% <ø> (-0.38%) ⬇️
pkg/koordlet/runtimehooks/protocol/pod_context.go 7.33% <0.00%> (ø)
pkg/koordlet/runtimehooks/reconciler/reconciler.go 65.88% <0.00%> (-1.18%) ⬇️
pkg/scheduler/plugins/coscheduling/core/gang.go 75.15% <0.00%> (-0.93%) ⬇️
pkg/util/httputil/reverseproxy.go 84.30% <0.00%> (-0.80%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@koordinator-bot koordinator-bot bot merged commit fd4432b into koordinator-sh:main Jan 12, 2023
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

FillZpp pushed a commit that referenced this pull request Jan 16, 2023
Signed-off-by: saintube <saintube@foxmail.com>
lucming pushed a commit to lucming/koordinator that referenced this pull request Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants