-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koordlet: fix batch resource plugin for empty label pods #952
koordlet: fix batch resource plugin for empty label pods #952
Conversation
Signed-off-by: saintube <saintube@foxmail.com>
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zwzhang0107 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Codecov ReportBase: 67.00% // Head: 66.97% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #952 +/- ##
==========================================
- Coverage 67.00% 66.97% -0.04%
==========================================
Files 243 243
Lines 28169 28166 -3
==========================================
- Hits 18876 18865 -11
- Misses 8006 8012 +6
- Partials 1287 1289 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Signed-off-by: saintube <saintube@foxmail.com>
…-sh#952) Signed-off-by: saintube <saintube@foxmail.com>
Signed-off-by: saintube saintube@foxmail.com
Ⅰ. Describe what this PR does
Fix the batch resource plugin when the BE pod has no label or annotation.
Also, fix some log format errors.
Ⅱ. Does this pull request fix one issue?
Currently, the batch resource plugin aborts set cgroup resources when a BE pod has no label or annotation since it checks if both of them are non-nil.
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test