Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apis: add extension plugin framework for PodMetric #955

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

jasonliu747
Copy link
Member

Signed-off-by: Jason Liu jasonliu747@gmail.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Base: 66.99% // Head: 66.97% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (d738c3f) compared to base (fd4432b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #955      +/-   ##
==========================================
- Coverage   66.99%   66.97%   -0.03%     
==========================================
  Files         243      243              
  Lines       28166    28166              
==========================================
- Hits        18871    18865       -6     
- Misses       8008     8012       +4     
- Partials     1287     1289       +2     
Flag Coverage Δ
unittests 66.97% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/util/httputil/reverseproxy.go 84.30% <0.00%> (-1.60%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@saintube
Copy link
Member

/lgtm

Signed-off-by: Jason Liu <jasonliu747@gmail.com>
@saintube
Copy link
Member

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Jan 13, 2023
@hormes
Copy link
Member

hormes commented Jan 13, 2023

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 360b573 into koordinator-sh:main Jan 13, 2023
lucming pushed a commit to lucming/koordinator that referenced this pull request Feb 8, 2023
Signed-off-by: Jason Liu <jasonliu747@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants