Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: clean up log format #962

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

wangxiaoq
Copy link
Contributor

@wangxiaoq wangxiaoq commented Jan 18, 2023

Signed-off-by: Wang Xiaoqiang wangxiaoqiang@qiyi.com

Ⅰ. Describe what this PR does

Clean up one invalid log format:

I0118 10:17:58.329530  111031 states_pods.go:274] record pod prometheus metrics successfully, pod koordinator-system%!(EXTRA string=koord-manager-6f579679ff-4m7nj)

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: Wang Xiaoqiang <wangxiaoqiang@qiyi.com>
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Base: 66.95% // Head: 66.98% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (fca9544) compared to base (86d8320).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #962      +/-   ##
==========================================
+ Coverage   66.95%   66.98%   +0.02%     
==========================================
  Files         243      243              
  Lines       28283    28283              
==========================================
+ Hits        18937    18944       +7     
+ Misses       8048     8041       -7     
  Partials     1298     1298              
Flag Coverage Δ
unittests 66.98% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/statesinformer/states_pods.go 62.05% <100.00%> (ø)
pkg/koordlet/runtimehooks/reconciler/reconciler.go 65.88% <0.00%> (+4.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@koordinator-bot koordinator-bot bot merged commit 97e92cb into koordinator-sh:main Jan 18, 2023
@wangxiaoq wangxiaoq deleted the fix-log branch January 18, 2023 03:41
lucming pushed a commit to lucming/koordinator that referenced this pull request Feb 8, 2023
Signed-off-by: Wang Xiaoqiang <wangxiaoqiang@qiyi.com>
@zwzhang0107 zwzhang0107 added this to the v1.2 milestone Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants