Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-scheduler: optimize DeviceShare plugins pod event handler #966

Merged

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Jan 30, 2023

Signed-off-by: Joseph joseph.t.lee@outlook.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@eahydra eahydra force-pushed the optimize_deviceshare_pod_handler branch from bf7542c to f864fa5 Compare January 30, 2023 13:20
@koordinator-bot koordinator-bot bot removed the lgtm label Jan 30, 2023
@koordinator-bot
Copy link

New changes are detected. LGTM label has been removed.

@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Base: 66.97% // Head: 66.91% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (f864fa5) compared to base (79ce5e0).
Patch coverage: 78.57% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #966      +/-   ##
==========================================
- Coverage   66.97%   66.91%   -0.07%     
==========================================
  Files         243      243              
  Lines       28287    28271      -16     
==========================================
- Hits        18946    18917      -29     
- Misses       8043     8055      +12     
- Partials     1298     1299       +1     
Flag Coverage Δ
unittests 66.91% <78.57%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/scheduler/plugins/deviceshare/pod_handler.go 88.05% <75.00%> (-7.13%) ⬇️
pkg/scheduler/plugins/deviceshare/plugin.go 88.81% <81.25%> (ø)
pkg/koordlet/runtimehooks/reconciler/reconciler.go 61.76% <0.00%> (-5.30%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hormes
Copy link
Member

hormes commented Jan 31, 2023

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 9a2d462 into koordinator-sh:main Jan 31, 2023
@eahydra eahydra added this to the v1.2 milestone Feb 7, 2023
lucming pushed a commit to lucming/koordinator that referenced this pull request Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants