Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-scheduler: Reservation resolves ReadWriteOncePodAccessMode volume conflict #969

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

KunWuLuan
Copy link
Contributor

fix #923

@eahydra eahydra changed the title support rwop koord-scheduler: Reservation resolves ReadWriteOncePodAccessMode volume conflict Jan 31, 2023
Signed-off-by: KunWuLuan <kunwuluan@gmail.com>
@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Base: 66.97% // Head: 66.97% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (c4eb14e) compared to base (79ce5e0).
Patch coverage: 62.50% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #969      +/-   ##
==========================================
- Coverage   66.97%   66.97%   -0.01%     
==========================================
  Files         243      244       +1     
  Lines       28287    28332      +45     
==========================================
+ Hits        18946    18976      +30     
- Misses       8043     8053      +10     
- Partials     1298     1303       +5     
Flag Coverage Δ
unittests 66.97% <62.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/scheduler/plugins/reservation/hook.go 75.62% <62.50%> (-1.39%) ⬇️
pkg/scheduler/plugins/deviceshare/pod_handler.go 88.05% <0.00%> (-7.13%) ⬇️
pkg/scheduler/plugins/deviceshare/plugin.go 87.71% <0.00%> (-1.11%) ⬇️
pkg/scheduler/plugins/deviceshare/device_cache.go 86.18% <0.00%> (-0.04%) ⬇️
pkg/scheduler/plugins/deviceshare/allocator.go 87.50% <0.00%> (ø)
pkg/util/httputil/reverseproxy.go 85.10% <0.00%> (+0.79%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 62ea125 into koordinator-sh:main Feb 2, 2023
@eahydra eahydra added this to the v1.2 milestone Feb 7, 2023
lucming pushed a commit to lucming/koordinator that referenced this pull request Feb 8, 2023
…me conflict (koordinator-sh#969)

Signed-off-by: KunWuLuan <kunwuluan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]Reservation can not be used with pvc in ReadWriteOncePod mode
4 participants