Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: PerformanceCollector supports cgroups-v2 #984

Merged
merged 3 commits into from
Feb 15, 2023

Conversation

Re-Grh
Copy link
Contributor

@Re-Grh Re-Grh commented Feb 3, 2023

Ⅰ. Describe what this PR does

PSI,CPI supports cgroups-v2

Ⅱ. Does this pull request fix one issue?

part of #407
fix:#972

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Base: 67.56% // Head: 67.48% // Decreases project coverage by -0.08% ⚠️

Coverage data is based on head (22bfcc8) compared to base (ddf7ad0).
Patch coverage: 44.09% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #984      +/-   ##
==========================================
- Coverage   67.56%   67.48%   -0.08%     
==========================================
  Files         251      251              
  Lines       28354    28435      +81     
==========================================
+ Hits        19156    19189      +33     
- Misses       7885     7922      +37     
- Partials     1313     1324      +11     
Flag Coverage Δ
unittests 67.48% <44.09%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/metricsadvisor/collector.go 43.34% <0.00%> (-0.46%) ⬇️
pkg/koordlet/resmanager/cpu_burst.go 73.07% <0.00%> (-0.67%) ⬇️
pkg/koordlet/resourceexecutor/executor.go 32.84% <0.00%> (ø)
...oordlet/runtimehooks/protocol/container_context.go 5.47% <0.00%> (-0.16%) ⬇️
pkg/koordlet/util/stat.go 57.69% <ø> (-1.82%) ⬇️
pkg/koordlet/util/system/cgroup_resource.go 80.51% <ø> (ø)
pkg/koordlet/util/system/cgroup.go 31.88% <31.03%> (+0.02%) ⬆️
pkg/koordlet/util/container.go 62.42% <33.33%> (-1.16%) ⬇️
pkg/koordlet/resourceexecutor/reader.go 64.63% <61.22%> (-2.04%) ⬇️
...dlet/metricsadvisor/performance_collector_linux.go 68.58% <63.63%> (-0.98%) ⬇️
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

pkg/koordlet/metricsadvisor/collector.go Show resolved Hide resolved
pkg/koordlet/metricsadvisor/collector.go Outdated Show resolved Hide resolved
pkg/koordlet/metricsadvisor/performance_collector_linux.go Outdated Show resolved Hide resolved
pkg/koordlet/resourceexecutor/reader.go Outdated Show resolved Hide resolved
pkg/koordlet/metricsadvisor/collector.go Outdated Show resolved Hide resolved
pkg/koordlet/metricsadvisor/collector.go Outdated Show resolved Hide resolved
pkg/koordlet/metricsadvisor/performance_collector_linux.go Outdated Show resolved Hide resolved
pkg/koordlet/resourceexecutor/executor.go Outdated Show resolved Hide resolved
@Re-Grh Re-Grh force-pushed the psi-v2 branch 7 times, most recently from 7e3f057 to 49730db Compare February 10, 2023 11:12
@Re-Grh Re-Grh force-pushed the psi-v2 branch 2 times, most recently from b7b4a17 to 239bfd4 Compare February 13, 2023 08:34
@Re-Grh Re-Grh force-pushed the psi-v2 branch 2 times, most recently from 246e2fb to 5527f35 Compare February 13, 2023 13:02
@saintube
Copy link
Member

/lgtm

pkg/koordlet/util/stat.go Outdated Show resolved Hide resolved
pkg/koordlet/resourceexecutor/reader.go Outdated Show resolved Hide resolved
pkg/koordlet/metricsadvisor/collector.go Outdated Show resolved Hide resolved
pkg/koordlet/resmanager/cpu_burst.go Show resolved Hide resolved
pkg/koordlet/resourceexecutor/reader.go Outdated Show resolved Hide resolved
pkg/koordlet/metricsadvisor/collector.go Outdated Show resolved Hide resolved
pkg/koordlet/metricsadvisor/collector.go Outdated Show resolved Hide resolved
pkg/koordlet/util/system/resource.go Outdated Show resolved Hide resolved
Signed-off-by: Re-Grh <1271013391@qq.com>
Signed-off-by: Re-Grh <1271013391@qq.com>
Signed-off-by: Re-Grh <1271013391@qq.com>
@zwzhang0107
Copy link
Contributor

/lgtm

@zwzhang0107
Copy link
Contributor

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zwzhang0107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@zwzhang0107 zwzhang0107 added this to the v1.2 milestone Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants