Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: optimize if-else logics in cgroup reconcile #992

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

lucming
Copy link
Contributor

@lucming lucming commented Feb 7, 2023

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Base: 67.50% // Head: 67.56% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (64c457d) compared to base (65849ae).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #992      +/-   ##
==========================================
+ Coverage   67.50%   67.56%   +0.06%     
==========================================
  Files         241      246       +5     
  Lines       27982    28149     +167     
==========================================
+ Hits        18889    19019     +130     
- Misses       7793     7825      +32     
- Partials     1300     1305       +5     
Flag Coverage Δ
unittests 67.56% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/resmanager/cgroup_reconcile.go 85.85% <100.00%> (-0.44%) ⬇️
pkg/util/cache/expiration_cache.go 74.60% <100.00%> (-1.16%) ⬇️
pkg/scheduler/plugins/loadaware/load_aware.go 73.81% <0.00%> (-3.28%) ⬇️
pkg/scheduler/plugins/coscheduling/core/gang.go 77.28% <0.00%> (-0.95%) ⬇️
...ler/apis/config/validation/validation_loadaware.go 0.00% <0.00%> (ø)
pkg/descheduler/utils/anomaly/types.go 0.00% <0.00%> (ø)
pkg/scheduler/plugins/loadaware/estimator/types.go 0.00% <0.00%> (ø)
pkg/descheduler/utils/anomaly/basic_detector.go 89.24% <0.00%> (ø)
...r/plugins/loadaware/estimator/default_estimator.go 97.91% <0.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zwzhang0107
Copy link
Contributor

PTAL @saintube

Signed-off-by: lucming <2876757716@qq.com>
Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@lucming please revise the title of the PR with the pattern koordlet: xxx

@koordinator-bot koordinator-bot bot added the lgtm label Feb 8, 2023
@jasonliu747 jasonliu747 changed the title just a few logical optimisations koordlet: optimize if-else logics in cgroup reconcile Feb 8, 2023
@zwzhang0107
Copy link
Contributor

/assign @FillZpp

@zwzhang0107
Copy link
Contributor

/approve

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FillZpp, jasonliu747, saintube, zwzhang0107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 645f4b1 into koordinator-sh:main Feb 9, 2023
@zwzhang0107 zwzhang0107 added this to the v1.2 milestone Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants