-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koordlet: optimize if-else logics in cgroup reconcile #992
Conversation
c7a25c3
to
5e9badb
Compare
Codecov ReportBase: 67.50% // Head: 67.56% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #992 +/- ##
==========================================
+ Coverage 67.50% 67.56% +0.06%
==========================================
Files 241 246 +5
Lines 27982 28149 +167
==========================================
+ Hits 18889 19019 +130
- Misses 7793 7825 +32
- Partials 1300 1305 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
PTAL @saintube |
Signed-off-by: lucming <2876757716@qq.com>
5e9badb
to
64c457d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@lucming please revise the title of the PR with the pattern koordlet: xxx
/assign @FillZpp |
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FillZpp, jasonliu747, saintube, zwzhang0107 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test