-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koord-scheduler: set Reservation indexer before informer start to avoid error #996
Conversation
4a18641
to
4d61dce
Compare
Codecov ReportBase: 67.59% // Head: 67.52% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #996 +/- ##
==========================================
- Coverage 67.59% 67.52% -0.08%
==========================================
Files 247 249 +2
Lines 28174 28190 +16
==========================================
- Hits 19043 19034 -9
- Misses 7829 7851 +22
- Partials 1302 1305 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
53c5123
to
a2d2113
Compare
…id error Signed-off-by: tzzcfrank <tzzcfrank@users.noreply.github.com>
a2d2113
to
1ce2c14
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eahydra, FillZpp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
If there is a new plugin that also starts the reservation informer during initialization, it will cause the reservation plugin to fail to register the indexer internally. The reason is that the k8s scheduling framework does not guarantee that the plugins are initialized in the order of configuration, even if the reservation plugin is configured first.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test