Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: correct import alias in states_nodemetric #999

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

jasonliu747
Copy link
Member

Signed-off-by: Jason Liu jasonliu747@gmail.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: Jason Liu <jasonliu747@gmail.com>
@koordinator-bot
Copy link

@jasonliu747: you cannot LGTM your own PR.

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member Author

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

@jasonliu747: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Base: 67.59% // Head: 67.53% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (b1d0f9b) compared to base (2b0f745).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #999      +/-   ##
==========================================
- Coverage   67.59%   67.53%   -0.06%     
==========================================
  Files         247      249       +2     
  Lines       28174    28190      +16     
==========================================
- Hits        19043    19038       -5     
- Misses       7829     7846      +17     
- Partials     1302     1306       +4     
Flag Coverage Δ
unittests 67.53% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/statesinformer/states_nodemetric.go 61.65% <100.00%> (ø)
pkg/scheduler/frameworkext/framework_extender.go 57.60% <0.00%> (-1.42%) ⬇️
pkg/scheduler/plugins/reservation/utils.go 78.57% <0.00%> (-0.71%) ⬇️
pkg/util/httputil/reverseproxy.go 84.30% <0.00%> (-0.54%) ⬇️
pkg/scheduler/plugins/reservation/hook.go 75.62% <0.00%> (ø)
...cheduler/plugins/reservation/garbage_collection.go 82.01% <0.00%> (ø)
pkg/scheduler/frameworkext/indexer/add_indexer.go 0.00% <0.00%> (ø)
pkg/scheduler/frameworkext/indexer/reservation.go 52.38% <0.00%> (ø)
pkg/scheduler/plugins/reservation/plugin.go 80.73% <0.00%> (+0.29%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@koordinator-bot koordinator-bot bot merged commit 5382446 into koordinator-sh:main Feb 9, 2023
@zwzhang0107 zwzhang0107 added this to the v1.2 milestone Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants