This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
Added instructions and script to release etcd-manager-ctl binaries #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@justinsb What's your take on this? |
|
This looks great - I'm going to merge it and try doing the next release with it :-) |
|
Thanks @pracucci /approve |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Engineers may require
etcd-manager-ctlto manage backups (ie. issue a restore command). Contrary toetcd-managerwhich gets shipped in a Docker image,etcd-manager-ctlis not strictly required to run in the same container while it can be run on any system having access to the remote storage (ie. engineer's workstation with privileges to read/write the related S3 bucket).In this PR I'm proposing to release
etcd-manager-ctlbinaries via GitHub release's assets. I haven't found any automatism to create the GitHub release, so I've assumed it's created manually at this stage.Fixes #201.