This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
Do not set ListenMetricsURLS #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
granular-ryanbonham
changed the title
justinsb
reviewed
Nov 23, 2020
granular-ryanbonham
force-pushed
the
368_restore_metrics_port
branch
from
eb8fc84
to
c781d9c
Compare
|
Thanks @granular-ryanbonham - nice fix! /approve |
justinsb
added a commit
to justinsb/kops
that referenced
this pull request
Dec 2, 2020
The important PR we want to pick up is 369, fixing a bug when ListenMetricsURLS is set as an env var. Full changelist: * Release notes for 3.0.20201117 [kubernetes#364](kopeio/etcd-manager#364) * Fix gofmt [kubernetes#365](kopeio/etcd-manager#365) * Add gofmt check to github actions [kubernetes#366](kopeio/etcd-manager#366) * Add boilerplate to tools/deb-tools/main.go [kubernetes#367](kopeio/etcd-manager#367) * Do not set ListenMetricsURLS [kubernetes#369](kopeio/etcd-manager#369) * Fix bazel formatting [kubernetes#370](kopeio/etcd-manager#370)
hakman
pushed a commit
to hakman/kops
that referenced
this pull request
Dec 2, 2020
The important PR we want to pick up is 369, fixing a bug when ListenMetricsURLS is set as an env var. Full changelist: * Release notes for 3.0.20201117 [kubernetes#364](kopeio/etcd-manager#364) * Fix gofmt [kubernetes#365](kopeio/etcd-manager#365) * Add gofmt check to github actions [kubernetes#366](kopeio/etcd-manager#366) * Add boilerplate to tools/deb-tools/main.go [kubernetes#367](kopeio/etcd-manager#367) * Do not set ListenMetricsURLS [kubernetes#369](kopeio/etcd-manager#369) * Fix bazel formatting [kubernetes#370](kopeio/etcd-manager#370)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.