This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
Support Azure #378
Merged
Support Azure #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add pkg/volumes/azure.
kenji-cloudnatix
force-pushed
the
azure2
branch
from
3df153d
to
1b6a50c
Compare
justinsb
reviewed
Dec 4, 2020
|
|
||
| return &client{ | ||
| metadata: m, | ||
| vmssesClient: &vmssesClient, |
There was a problem hiding this comment.
Nit: These fields names are hard to read at first. It might be clearer to drop client and just go with scaleSets, scaleSetVMs, disks and networkInterfaces.
But OTOH I'm also new to the azure SDK, so this might just be because I'm not familiar with it all!
There was a problem hiding this comment.
Agreed! Let me fix with a separate PR.
|
This looks great - thanks @kenji-cloudnatix /approve |
kenji-cloudnatix
commented
Dec 4, 2020
|
|
||
| return &client{ | ||
| metadata: m, | ||
| vmssesClient: &vmssesClient, |
There was a problem hiding this comment.
Agreed! Let me fix with a separate PR.
kenji-cloudnatix
added a commit
to cloudnatix/etcd-manager-public
that referenced
this pull request
Dec 4, 2020
Make them easier to read as suggested in kopeio#378.
justinsb
pushed a commit
to justinsb/etcdadm
that referenced
this pull request
Dec 5, 2020
Make them easier to read as suggested in kopeio/etcd-manager#378.
justinsb
added a commit
to justinsb/kops
that referenced
this pull request
Dec 9, 2020
Highlights: * Fix arm64 images, which were built with an incorrect base image. * Initial (experimental) Azure support Full change list: * Update Kops dependency for Azure Blob Storage support [kubernetes#372](kopeio/etcd-manager#372) * Exclude gazelle from tools/deb-tools [kubernetes#373](kopeio/etcd-manager#373) * Regenerate bazel in tools/deb-tools [kubernetes#374](kopeio/etcd-manager#374) * Release notes for 3.0.20201202 [kubernetes#375](kopeio/etcd-manager#375) * Remove travis CI [kubernetes#377](kopeio/etcd-manager#377) * Fix vendor generation for tools/deb-tools subproject [kubernetes#376](kopeio/etcd-manager#376) * Add script to verify image hashes [kubernetes#380](kopeio/etcd-manager#380) * Fix some incorrect base image hashes for arm64 [kubernetes#379](kopeio/etcd-manager#379) * Support Azure [kubernetes#378](kopeio/etcd-manager#378) * Add more descriptions to wait loops [kubernetes#383](kopeio/etcd-manager#383) * Rename fields in the azure client struct [kubernetes#382](kopeio/etcd-manager#382) * Fix small typo in code comment [kubernetes#381](kopeio/etcd-manager#381)
hakman
pushed a commit
to hakman/kops
that referenced
this pull request
Dec 9, 2020
Highlights: * Fix arm64 images, which were built with an incorrect base image. * Initial (experimental) Azure support Full change list: * Update Kops dependency for Azure Blob Storage support [kubernetes#372](kopeio/etcd-manager#372) * Exclude gazelle from tools/deb-tools [kubernetes#373](kopeio/etcd-manager#373) * Regenerate bazel in tools/deb-tools [kubernetes#374](kopeio/etcd-manager#374) * Release notes for 3.0.20201202 [kubernetes#375](kopeio/etcd-manager#375) * Remove travis CI [kubernetes#377](kopeio/etcd-manager#377) * Fix vendor generation for tools/deb-tools subproject [kubernetes#376](kopeio/etcd-manager#376) * Add script to verify image hashes [kubernetes#380](kopeio/etcd-manager#380) * Fix some incorrect base image hashes for arm64 [kubernetes#379](kopeio/etcd-manager#379) * Support Azure [kubernetes#378](kopeio/etcd-manager#378) * Add more descriptions to wait loops [kubernetes#383](kopeio/etcd-manager#383) * Rename fields in the azure client struct [kubernetes#382](kopeio/etcd-manager#382) * Fix small typo in code comment [kubernetes#381](kopeio/etcd-manager#381)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pkg/volumes/azure.