Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kwargs #15

Merged
merged 6 commits into from Nov 19, 2017
Merged

Remove kwargs #15

merged 6 commits into from Nov 19, 2017

Conversation

kopf
Copy link
Owner

@kopf kopf commented Nov 19, 2017

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 94.915% when pulling 684b61d on remove_kwargs into 1a5e76d on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 94.915% when pulling 684b61d on remove_kwargs into 1a5e76d on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 94.915% when pulling 684b61d on remove_kwargs into 1a5e76d on master.

@coveralls
Copy link

coveralls commented Nov 19, 2017

Coverage Status

Coverage increased (+1.4%) to 96.581% when pulling 52ee415 on remove_kwargs into 1a5e76d on master.

@oliverlockwood
Copy link
Contributor

LGTM, though I expect there may end up being some merge conflicts with #14.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.4%) to 96.667% when pulling 2a917a1 on remove_kwargs into 96ad441 on master.

1 similar comment
@coveralls
Copy link

coveralls commented Nov 19, 2017

Coverage Status

Coverage increased (+1.4%) to 96.667% when pulling 2a917a1 on remove_kwargs into 96ad441 on master.

@coveralls
Copy link

coveralls commented Nov 19, 2017

Coverage Status

Coverage increased (+1.4%) to 96.667% when pulling 90226ca on remove_kwargs into 96ad441 on master.

@kopf kopf merged commit 89ac75f into master Nov 19, 2017
@kopf
Copy link
Owner Author

kopf commented Nov 19, 2017

@oliverlockwood ok, i've merged this and have tagged and released v0.3.0 - https://pypi.python.org/pypi/httsleep/0.3.0

enjoy! and let me know if you run into any problems.

@oliverlockwood
Copy link
Contributor

@kopf I've updated our code to use the latest syntax with version 0.3.0 of httsleep, and all looks good so far. Cheers!

@kopf
Copy link
Owner Author

kopf commented Nov 20, 2017

Great! Thanks for your time and work implementing these improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants