Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(snapshots): panic: unaligned 64-bit atomic operation #2151

Merged
merged 1 commit into from
Jul 7, 2022

Conversation

jkowalski
Copy link
Contributor

Reverted to regular sync.Pool

Fixes #2150

@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #2151 (b1b6ac6) into master (04fe236) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2151      +/-   ##
==========================================
- Coverage   73.46%   73.43%   -0.04%     
==========================================
  Files         425      425              
  Lines       33003    33000       -3     
==========================================
- Hits        24245    24232      -13     
- Misses       6974     6984      +10     
  Partials     1784     1784              
Impacted Files Coverage Δ
internal/freepool/freepool.go 100.00% <100.00%> (ø)
cli/command_content_verify.go 75.00% <0.00%> (-6.04%) ⬇️
repo/blob/throttling/throttling_semaphore.go 97.05% <0.00%> (-2.95%) ⬇️
repo/grpc_repository_client.go 75.45% <0.00%> (-0.67%) ⬇️
internal/epoch/epoch_manager.go 89.60% <0.00%> (-0.52%) ⬇️
snapshot/snapshotfs/upload.go 79.68% <0.00%> (+0.11%) ⬆️
repo/content/content_manager_iterate.go 91.71% <0.00%> (+2.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04fe236...b1b6ac6. Read the comment docs.

@jkowalski jkowalski merged commit aec08c8 into kopia:master Jul 7, 2022
@ptandler
Copy link

ptandler commented Jul 7, 2022

Great that you fixed this! ❤️ Already planned when a version with this fix will be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in v0.11.1: panic: unaligned 64-bit atomic operation
3 participants