refactor(cli): break down observability.startMetrics() #3196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julio-lopez
force-pushed
the
refactor/observability
branch
from
5327140
to
02dd230
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3196 +/- ##
==========================================
- Coverage 75.43% 75.41% -0.02%
==========================================
Files 459 459
Lines 36456 36465 +9
==========================================
Hits 27501 27501
- Misses 7042 7048 +6
- Partials 1913 1916 +3
☔ View full report in Codecov by Sentry. |
Motivation: reduce the function complexity for the linter, so additional functionality can be added to `startMetrics()` No functional changes.
julio-lopez
force-pushed
the
refactor/observability
branch
from
02dd230
to
ab5b830
Compare
Reduce indentation by returning early
Reduce indentation by returning early
|
LGTM on the direction. |
jkowalski
approved these changes
Aug 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: reduce the function complexity for the linter, so additional functionality can be added to
startMetrics()No functional changes.
Breaks down
observability.startMetrics()into:maybeStartListenermaybeStartMetricsPushermaybeStartTraceExporter