Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(cli): break down observability.startMetrics() #3196

Merged
merged 5 commits into from Aug 6, 2023
Merged

refactor(cli): break down observability.startMetrics() #3196

merged 5 commits into from Aug 6, 2023

Commits on Aug 6, 2023

  1. refactor(cli): break down observability.startMetrics() 

    Motivation: reduce the function complexity for the linter, so additional
functionality can be added to `startMetrics()`

No functional changes.
    @julio-lopez
    julio-lopez committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    ea5f86e View commit details
    Browse the repository at this point in the history

  2. refactor(cli): inline observabilityFlags.getExporter in maybeStartTra… 

    …ceExporter
    @julio-lopez
    julio-lopez committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    e3c3356 View commit details
    Browse the repository at this point in the history

  3. refactor(cli): only create resource when exporter is non-nil

    @julio-lopez
    julio-lopez committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    ab5b830 View commit details
    Browse the repository at this point in the history

  4. Simplify maybeStartListener 

    Reduce indentation by returning early
    @julio-lopez
    julio-lopez committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    42deeec View commit details
    Browse the repository at this point in the history

  5. Simplify maybeStartMetricsPusher 

    Reduce indentation by returning early
    @julio-lopez
    julio-lopez committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    9d2a6db View commit details
    Browse the repository at this point in the history