-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(repository): BREAKING CHANGE remove support for HTTP-based repository API #3745
chore(repository): BREAKING CHANGE remove support for HTTP-based repository API #3745
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3745 +/- ##
==========================================
+ Coverage 75.86% 77.05% +1.19%
==========================================
Files 470 473 +3
Lines 37301 28656 -8645
==========================================
- Hits 28299 22082 -6217
+ Misses 7071 4680 -2391
+ Partials 1931 1894 -37 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor suggestions but looks good.
serverStartGRPC bool | ||
serverStartControlAPI bool | ||
serverStartUI bool | ||
serverStartGRPC bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need the option of disabling the GRPC handler setup?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this allows one to create UI-only server, without supporting repository API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth renaming the --no-grpc
flag then to be more descriptive of the use case? --ui-only
or --[no-]repository-api
maybe?
} | ||
|
||
//nolint:thelper | ||
func testAPIServerRepository(t *testing.T, serverStartArgs []string, useGRPC, allowRepositoryUsers bool) { | ||
func testAPIServerRepository(t *testing.T, allowRepositoryUsers bool) { | ||
ctx := testlogging.Context(t) | ||
|
||
var connectArgs []string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is now unused/empty. Worth removing?
var connectArgs []string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done, also cleaned up below
3e1d517
to
9ceefa3
Compare
Now that we've released v0.16.0 this removes the repositrory API support over HTTP as described in #3716.
This removes flags:
--[no-]legacy-api
inkopia server start
(defaulted tofalse
in v0.16.0)--[no-]grpc
inkopia repository server connect
(defaulted totrue
in v0.16.0)Note: This change is targeting v0.17.0 and is not meant to be merged merged immediately, in case we need to make hotfix patches on top of v0.16.0