Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository password change support #1197

Merged
merged 7 commits into from Jul 17, 2021

Conversation

jkowalski
Copy link
Contributor

This will only work for new repositories, since there's now a repository-wide flag that disables replication of kopia.repository contents in all packs.

@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

Merging #1197 (de8cac8) into master (bffe8b3) will increase coverage by 0.10%.
The diff coverage is 62.79%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1197      +/-   ##
==========================================
+ Coverage   67.88%   67.98%   +0.10%     
==========================================
  Files         358      360       +2     
  Lines       21068    21132      +64     
==========================================
+ Hits        14302    14367      +65     
- Misses       5231     5232       +1     
+ Partials     1535     1533       -2     
Impacted Files Coverage Δ
cli/password.go 10.71% <0.00%> (-2.93%) ⬇️
repo/content/content_formatting_options.go 100.00% <ø> (ø)
repo/initialize.go 78.78% <50.00%> (+0.32%) ⬆️
repo/parameters.go 50.00% <50.00%> (ø)
repo/change_password.go 57.89% <57.89%> (ø)
cli/command_repository_change_password.go 65.00% <65.00%> (ø)
repo/open.go 67.85% <89.47%> (+5.51%) ⬆️
cli/command_repository.go 100.00% <100.00%> (ø)
cli/command_repository_create.go 74.11% <100.00%> (+0.62%) ⬆️
cli/command_repository_repair.go 78.84% <100.00%> (+5.76%) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bffe8b3...de8cac8. Read the comment docs.

@jkowalski jkowalski marked this pull request as ready for review July 15, 2021 18:50
Copy link
Collaborator

@julio-lopez julio-lopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a nit.

cliOpts ClientOptions
timeNow func() time.Time
formatBlob *formatBlob
formatEncryptionKey []byte
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

cli/command_repository_change_password.go Outdated Show resolved Hide resolved
Co-authored-by: Julio Lopez <julio+gh@kasten.io>
@jkowalski jkowalski merged commit 730ba7b into kopia:master Jul 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants