Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: fixed 'snapshot list --json --max-results' #1529

Merged
merged 1 commit into from Nov 21, 2021

Conversation

jkowalski
Copy link
Contributor

Fixes #1455

@codecov
Copy link

codecov bot commented Nov 21, 2021

Codecov Report

Merging #1529 (a18a8e9) into master (525720d) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1529      +/-   ##
==========================================
+ Coverage   68.90%   69.04%   +0.14%     
==========================================
  Files         374      374              
  Lines       29652    29657       +5     
==========================================
+ Hits        20433    20478      +45     
+ Misses       7531     7505      -26     
+ Partials     1688     1674      -14     
Impacted Files Coverage Δ
cli/command_snapshot_list.go 60.26% <100.00%> (+0.90%) ⬆️
cli/command_content_verify.go 73.68% <0.00%> (-5.27%) ⬇️
repo/content/committed_read_manager.go 70.29% <0.00%> (+0.81%) ⬆️
repo/maintenance/maintenance_run.go 75.97% <0.00%> (+0.90%) ⬆️
internal/server/server.go 66.96% <0.00%> (+1.77%) ⬆️
internal/cache/persistent_lru_cache.go 84.37% <0.00%> (+1.87%) ⬆️
internal/ownwrites/ownwrites.go 81.13% <0.00%> (+2.83%) ⬆️
internal/epoch/epoch_manager.go 89.18% <0.00%> (+2.84%) ⬆️
repo/content/index_blob_manager_v1.go 69.56% <0.00%> (+3.26%) ⬆️
repo/maintenance/maintenance_schedule.go 71.55% <0.00%> (+5.17%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 525720d...a18a8e9. Read the comment docs.

@jkowalski jkowalski merged commit 8ab3e04 into kopia:master Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

snapshot list "--max-results" flag not used when "--json" flag is used
1 participant