Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

policy: revamped policy merge mechanism #1538

Merged
merged 1 commit into from Nov 28, 2021

Conversation

jkowalski
Copy link
Contributor

Added policy.Definition which allows us to precisely report where
each piece of policy came from.

Fixed a one-off bug with "noParent", which prevented merging of parent
policies one level too soon.

Added a whole bunch of merging helpers and generic reflection-based
test that ensures every single merge is tested.

Added policy.Definition which allows us to precisely report where
each piece of policy came from.

Fixed a one-off bug with "noParent", which prevented merging of parent
policies one level too soon.

Added a whole bunch of merging helpers and generic reflection-based
test that ensures every single merge is tested.
@codecov
Copy link

codecov bot commented Nov 26, 2021

Codecov Report

Merging #1538 (a929b90) into master (b91d8ac) will increase coverage by 0.20%.
The diff coverage is 89.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1538      +/-   ##
==========================================
+ Coverage   68.94%   69.15%   +0.20%     
==========================================
  Files         374      375       +1     
  Lines       29657    29639      -18     
==========================================
+ Hits        20447    20496      +49     
+ Misses       7525     7474      -51     
+ Partials     1685     1669      -16     
Impacted Files Coverage Δ
snapshot/policy/log_detail.go 100.00% <ø> (ø)
snapshot/policy/optional.go 100.00% <ø> (ø)
snapshot/policy/policy.go 88.88% <ø> (+13.41%) ⬆️
snapshot/policy/policy_tree.go 100.00% <ø> (ø)
snapshot/policy/policy_manager.go 72.90% <44.44%> (ø)
cli/command_policy_show.go 57.43% <67.74%> (-3.95%) ⬇️
cli/command_repository_create.go 69.44% <100.00%> (ø)
cli/command_snapshot_list.go 60.26% <100.00%> (ø)
internal/server/api_snapshots.go 83.01% <100.00%> (ø)
internal/server/source_manager.go 75.57% <100.00%> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b91d8ac...a929b90. Read the comment docs.

@jkowalski jkowalski merged commit 93930d2 into kopia:master Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant