logging: added log rotation and improved predictability of log sweep #1562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1562 +/- ##
==========================================
+ Coverage 69.18% 69.26% +0.08%
==========================================
Files 375 375
Lines 29795 29866 +71
==========================================
+ Hits 20614 20688 +74
+ Misses 7501 7496 -5
- Partials 1680 1682 +2
Continue to review full report at Codecov.
|
With this change logs will be rotated every 50 MB, which prevents accumulation of giant files while server is running. This change will also guarantee that log sweep completes at least once before each invocation of Kopia finishes. Previously it was a goroutine that was not monitored for completion. Flags can be used to override default behaviors: * `--max-log-file-segment-size` * `--no-wait-for-log-sweep` - disables waiting for full log sweep Fixes kopia#1561
This limits the total size of all logs in a directory to 1 GB.
jkowalski
force-pushed
the
long-running-log-sweep
branch
from
bb9c410
to
0ce3ec0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change logs will be rotated every 50 MB, which prevents
accumulation of giant files while server is running.
This change will also guarantee that log sweep completes at least once
before each invocation of Kopia finishes. Previously it was a goroutine
that was not monitored for completion.
Flags can be used to override default behaviors:
--max-log-file-segment-size--no-wait-for-log-sweep- disables waiting for full log sweepFixes #1561