Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(snapshots): Partly fix #544 by supporting setuid/setgid/sticky bits … #2597

Merged
merged 1 commit into from
Dec 7, 2022
Merged

fix(snapshots): Partly fix #544 by supporting setuid/setgid/sticky bits … #2597

merged 1 commit into from
Dec 7, 2022

Conversation

lciti
Copy link
Contributor

@lciti lciti commented Nov 23, 2022

…when snapshotting, restoring and fuse-mounting.

Also modified an end-to-end test to also check that these extra mode flags work when snapshotting+restoring. Manually tested fuse-mount.

…ting, restoring and fuse-mounting.

Also modified an end-to-end test to also check that these extra mode flags work when snapshotting+restoring.
Manually tested fuse-mount.
@codecov
Copy link

codecov bot commented Nov 26, 2022

Codecov Report

Base: 74.86% // Head: 74.91% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (4774377) compared to base (fa5aaa4).
Patch coverage: 11.76% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2597      +/-   ##
==========================================
+ Coverage   74.86%   74.91%   +0.04%     
==========================================
  Files         452      452              
  Lines       35478    35491      +13     
==========================================
+ Hits        26562    26587      +25     
+ Misses       7030     7026       -4     
+ Partials     1886     1878       -8     
Impacted Files Coverage Δ
fs/entry.go 93.87% <ø> (ø)
internal/fusemount/fusefs.go 0.00% <0.00%> (ø)
snapshot/restore/local_fs_output.go 65.27% <50.00%> (ø)
snapshot/snapshotfs/upload.go 85.28% <100.00%> (ø)
internal/epoch/epoch_manager.go 85.29% <0.00%> (+0.48%) ⬆️
repo/content/index/index_v1.go 76.17% <0.00%> (+1.17%) ⬆️
internal/server/source_manager.go 82.95% <0.00%> (+2.29%) ⬆️
cli/command_content_verify.go 81.51% <0.00%> (+5.88%) ⬆️
internal/dirutil/mksubdirall.go 100.00% <0.00%> (+7.89%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lciti lciti changed the title Partly fix #544 by supporting setuid/setgid/sticky bits … fix(snapshots): Partly fix #544 by supporting setuid/setgid/sticky bits … Nov 26, 2022
@lciti
Copy link
Contributor Author

lciti commented Nov 29, 2022

I don't think the Windows failed test has anything to do with the PR. Is there anything left for me to do before this is ready to be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants