Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): log cache full when on debug level #3085

Merged
merged 9 commits into from Aug 3, 2023
Merged

fix(cli): log cache full when on debug level #3085

Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
267ba78
Log full cache when on debug level
arouene Jun 19, 2023
0a968ea
Change log level to warning
arouene Jun 28, 2023
cd2cacb
Merge branch 'master' into log-cache-full
Jun 28, 2023
742f41e
Fix typo
arouene Jun 28, 2023
45972b8
Merge branch 'master' into log-cache-full
jkowalski Jul 4, 2023
5941443
Add rate limit to one warning max per minute
arouene Jul 5, 2023
12c5357
Merge branch 'master' into log-cache-full
Jul 25, 2023
9d61635
Make the time var inside PersistentCache struct
arouene Aug 1, 2023
94b35e7
Fix lint errors
arouene Aug 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions internal/cache/persistent_lru_cache.go
View file
Open in desktop
Expand Up @@ -231,6 +231,7 @@ func (c *PersistentCache) Put(ctx context.Context, key string, data gather.Bytes
// MUST NOT go over the specified limit for the cache space to avoid
// snapshots/restores from getting affected by the cache's storage use.
if c.isCacheFullLocked() {
log(ctx).Warnf("Cache is full, unable to add %v into cache.", key)
arouene marked this conversation as resolved.
Show resolved Hide resolved
return
}
}
Expand Down