Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(general): use non-formatting log variants when there is no formatting #3931

Merged
merged 10 commits into from
Jun 19, 2024

Conversation

julio-lopez
Copy link
Collaborator

Use non-formatting logging functions for message without formatting.
For example, log.Info("message") instead of log.Infof("message")

Configure linter for printf-like functions

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 66.90141% with 47 lines in your changes missing coverage. Please review.

Project coverage is 77.24%. Comparing base (cb455c6) to head (3815fe6).
Report is 169 commits behind head on master.

Files Patch % Lines
cli/command_mount.go 0.00% 5 Missing ⚠️
cli/command_repository_set_client.go 42.85% 4 Missing ⚠️
repo/maintenance/maintenance_run.go 76.47% 4 Missing ⚠️
cli/update_check.go 0.00% 3 Missing ⚠️
internal/server/source_manager.go 0.00% 3 Missing ⚠️
cli/command_snapshot_list.go 0.00% 2 Missing ⚠️
...nternal/passwordpersist/passwordpersist_keyring.go 0.00% 2 Missing ⚠️
repo/content/content_manager.go 66.66% 2 Missing ⚠️
cli/auto_upgrade.go 0.00% 1 Missing ⚠️
cli/command_blob_gc.go 0.00% 1 Missing ⚠️
... and 20 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3931      +/-   ##
==========================================
+ Coverage   75.86%   77.24%   +1.37%     
==========================================
  Files         470      481      +11     
  Lines       37301    28803    -8498     
==========================================
- Hits        28299    22249    -6050     
+ Misses       7071     4657    -2414     
+ Partials     1931     1897      -34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@julio-lopez julio-lopez marked this pull request as ready for review June 19, 2024 05:50
@julio-lopez julio-lopez enabled auto-merge (squash) June 19, 2024 05:50
@julio-lopez julio-lopez merged commit 1f9f9a1 into kopia:master Jun 19, 2024
26 of 27 checks passed
@julio-lopez julio-lopez deleted the nit/log branch June 19, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant