cli: plumbed through missing --server-cert-fingerprint option #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julio-lopez
approved these changes
Sep 2, 2020
jkowalski
referenced
this pull request
in jkowalski/kopia
Mar 13, 2021
This is for a scenario where a user provides valid username/password but such that the username is not authorized to access the UI. Previously we'd make it look like they got access (because they can see the UI at leaast partially), but all API calls would fail. With this change we're failing early with HTTP 403 and pointing the users at a GH issue explaining what to do. Fixes #580.
jkowalski
added a commit
that referenced
this pull request
Mar 13, 2021
…r than the UI user (#884) This is for a scenario where a user provides valid username/password but such that the username is not authorized to access the UI. Previously we'd make it look like they got access (because they can see the UI at leaast partially), but all API calls would fail. With this change we're failing early with HTTP 403 and pointing the users at a GH issue explaining what to do. Fixes #580.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #577