Update dependencies #639
Merged
Update dependencies #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
September 22, 2020 20:14
cloud.google.com/go/storage to v1.12.0 from version 1.8.0 - https://github.com/googleapis/google-cloud-go/releases/tag/storage%2Fv1.12.0 google.golang.org/protobuf to 1.25.0 - https://github.com/protocolbuffers/protobuf-go/releases/tag/v1.25.0 google.golang.org/api from 0.25 to 0.32.0 - https://github.com/googleapis/google-api-go-client/releases Also upgrade golang.org/x dependencies
Promethes client to 1.7.0 https://github.com/prometheus/client_golang/releases/tag/v1.7.0 Opencensus to 0.22.4 https://github.com/census-instrumentation/opencensus-go/releases/tag/v0.22.4 Opencensus prometheus exporter to v0.2.0 https://github.com/census-ecosystem/opencensus-go-exporter-prometheus/releases/tag/v0.2.0
Fixes an issue when working with relative directories
https://github.com/google/go-cloud/releases/tag/v0.20.0 Also upgrades Azure storage blob to 0.10.0 https://github.com/Azure/azure-storage-blob-go/releases/tag/v0.10.0 as well as other Azure dependencies azure-amqp-common-go v2.1.0 => v2.1.0 azure-pipeline-go v0.2.2 => v0.2.3
github.com/klauspost/compress to v1.11.0 github.com/klauspost/pgzip to v1.2.5
jkowalski
approved these changes
Sep 23, 2020
jkowalski
reviewed
Sep 23, 2020
| github.com/natefinch/atomic v0.0.0-20150920032501-a62ce929ffcc | ||
| github.com/mattn/go-colorable v0.1.7 // indirect | ||
| github.com/minio/minio v0.0.0-20200922223427-0537a21b7948 | ||
| github.com/minio/minio-go/v6 v6.0.58-0.20200612001654-a57fec8037ec |
There was a problem hiding this comment.
can we upgrade to v7?
also, can we get rid of minio/minio which is only used in tests.
There was a problem hiding this comment.
go mod will include dependencies even if they are only used in test or in a different platform.
I can push a separate patch to upgrade to v7, in case there are any issues with it to at least upgrade the rest.
There was a problem hiding this comment.
The test depends on this "github.com/minio/minio/pkg/madmin" - I was wondering whether there's equivalent in v7 package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combo dependency updates, since many had fallen behind.