Makefile: various tricks to make PR builds faster #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julio-lopez
approved these changes
Dec 18, 2020
| @@ -97,6 +102,12 @@ html-ui-bindata-fallback: $(go_bindata) | |||
| kopia-ui: | |||
| $(MAKE) -C app build-electron | |||
|
|
|||
| # build-current-os compiles a binary for the current os/arch in the same location as goreleaser | |||
| # kopia-ui build needs this particular location to embed the correct server binary. | |||
| # the binary does not embed actual UI. | |||
There was a problem hiding this comment.
# the binary does not embed actual UI.
😕 Not sure I understand the comment. I appears to me as if the UI is being embedded.
- The target depends on
html-ui-bindatawhich generateshtmlui_bindata.gowith anembedhtmlbuild tag. - Then this builds the kopia binary and specifies the
enbedhtmlbuild tag.
I'm probably missing something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.