Added support for user authentication using user profiles stored in the repository #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkowalski
force-pushed
the
repository-user-authentication
branch
from
84a4ac1
to
a68ae3a
Compare
julio-lopez
reviewed
Feb 3, 2021
|
|
||
| salt := data[0:v1SaltLength] | ||
|
|
||
| h := computePasswordHashV1(password, salt) |
There was a problem hiding this comment.
Is the password checked on every request? or when a connection is established (and potentially reused for multiple requests)?
Is scrypt.Key going to blow up memory consumption for the server?
There was a problem hiding this comment.
the password will be checked once per stream in GRPC session and once per request in the REST case. Given that we're deprecating the REST server soon, this should practically not matter, since no user is currently using repository-based accounts.
Co-authored-by: Julio López <julio+gh@kasten.io>
jkowalski
force-pushed
the
repository-user-authentication
branch
from
3628000
to
7b8a6f4
Compare
julio-lopez
reviewed
Feb 4, 2021
|
@pavannd1 PTAL when you have a chance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to htpasswd-based authentication. Users can be added and manipulated using CLI and are stored in a repository as manifests of type
user.