Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paste of Google URL #254

Closed
koppor opened this issue Sep 4, 2017 · 3 comments
Closed

Paste of Google URL #254

koppor opened this issue Sep 4, 2017 · 3 comments

Comments

@koppor
Copy link
Owner

koppor commented Sep 4, 2017

We had a functionality to cleanup Google URLs. This should be transparent for the user.

grafik

@zeabin
Copy link

zeabin commented Jul 10, 2018

Hi, @koppor . I am a newcomer to this project and find this issue may be a good one to try. I notice that someone had tried to contribute to it but somehow gave it up. JabRef#3394 Does this issue still need to be done now?

@koppor
Copy link
Owner Author

koppor commented Jul 11, 2018

JabRef#3394 is closed with unmerged commits. So, the functionality is not in JabRef.

You can do following: Create a new branch at your side, copy and paste the changes from https://github.com/JabRef/jabref/pull/3394/files, address the comments from JabRef#3394 (e.g., "Avoid the non null annotation and use Objects.requireNonNulll", "Description should be localized, too") and create a new pull request.

Reference this issue from the pull request.

We really look forward to get this into JabRef.

@tobiasdiez
Copy link
Collaborator

This is now implemented in the latest development version thanks to @1161140207. Could you please check the build from http://builds.jabref.org/master/. Thanks! Please remember to make a backup of your library before trying-out this version.

calixtus pushed a commit that referenced this issue Apr 19, 2022
c6e38e6963 en-GB & en-US: Add missing form attribute to terms (#254)

git-subtree-dir: buildres/csl/csl-locales
git-subtree-split: c6e38e6963a9792332c63ea3c3c385176f76f7ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants