Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace margin with gap for container components #109

Closed
25 tasks done
eduferfer opened this issue Apr 17, 2022 · 0 comments
Closed
25 tasks done

Replace margin with gap for container components #109

eduferfer opened this issue Apr 17, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@eduferfer
Copy link
Collaborator

eduferfer commented Apr 17, 2022

Is your feature request related to a problem? Please describe.
Containers use spacing rules based on css margin which may conflict with margin rules of the slotted content itself.

Describe the solution you'd like
Instead, kor containers could be based on flex/grid gap rules, which are now supported by all modern browsers

  • modularize container css props & add js doc
    • card (--body-gap, --header-gap, --functions-gap, --footer-gap)
    • app-bar (--functions-gap)
    • empty-state (--footer-gap)
    • notifications (--body-gap)
  • bind encapsulated css props to inner modal & add js doc
    • accordion (--body-gap, --header-gap, --functions-gap, --footer-gap)
    • modal (--body-gap, --header-gap, --functions-gap, --footer-gap)
    • drawer (--body-gap, --header-gap, --functions-gap, --footer-gap)
    • popover (--body-gap, --header-gap, --functions-gap, --footer-gap)
    • tooltip (--body-gap, --header-gap, --functions-gap, --footer-gap)
    • notification-item (--body-gap, --header-gap, --functions-gap, --footer-gap)
    • pane (--body-gap, --header-gap, --functions-gap, --footer-gap)
  • document
    • accordion
    • app-bar
    • card
    • drawer
    • empty-state
    • modal
    • notifications
    • notification-item
    • pane
    • popover
    • tooltip
eduferfer added a commit that referenced this issue Apr 17, 2022
eduferfer added a commit that referenced this issue Apr 17, 2022
eduferfer added a commit that referenced this issue Apr 17, 2022
eduferfer added a commit that referenced this issue Apr 17, 2022
eduferfer added a commit that referenced this issue Apr 17, 2022
eduferfer added a commit that referenced this issue Apr 17, 2022
@eduferfer eduferfer added the enhancement New feature or request label Apr 17, 2022
@eduferfer eduferfer self-assigned this Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant