Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need slot in kor-tab-item #48

Closed
damodharanj opened this issue Dec 12, 2020 · 3 comments · Fixed by #49
Closed

Need slot in kor-tab-item #48

damodharanj opened this issue Dec 12, 2020 · 3 comments · Fixed by #49

Comments

@damodharanj
Copy link

I need to place anchor tab inside tab-item. Right now it does not render the anchor inside a tab-item

@eduferfer
Copy link
Collaborator

Hi @damodharanj , could the anchor also be placed outside of the tab-item like below or is there a limitation to that on how your DOM is structured?

<a href="...">
  <kor-tab-item label="Hi"></kor-tab-item>
</a>

Alternatively, would it suffice if the tab-item itself would have an href property to handle URL navigation like below?

<kor-tab-item label="Hi" href="..."></kor-tab-item>

@damodharanj
Copy link
Author

<a href="...">
  <kor-tab-item label="Hi"></kor-tab-item>
</a>

In this case the kor-tabs component is not working as intended

Screen Shot 2020-12-12 at 6 09 23 PM

The underline does not toggle


<kor-tab-item label="Hi" href="..."></kor-tab-item>

This might not be sufficient as one might use custom Link tags the router supports. https://www.npmjs.com/package/lit-element-router


eduferfer added a commit that referenced this issue Dec 12, 2020
@eduferfer
Copy link
Collaborator

@damodharanj I just published a patch (v1.4.2) which allows <a> or any other element to be between <kor-tabs> and <kor-tab-item>.

Please try it out and let me know if it solves the problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants