Don't output trailing delimiter if the input doesn't contain one #14
Comments
Freaky
added a commit
to Freaky/huniq
that referenced
this issue
Oct 17, 2020
This replaces the custom split_read_zerocopy with bstr's own minimally-copying record reader, which simplifies the code somewhat without sacrificing performance in any of my measurements (98% - 115% observed performance against baseline) This also removes the sysconf dependency, which caused a compile error here on FreeBSD. This also adds a --no-trailing-delimiter flag requested in koraa#14, since this code needed to be moved anyway.
koraa
pushed a commit
that referenced
this issue
Oct 27, 2020
This replaces the custom split_read_zerocopy with bstr's own minimally-copying record reader, which simplifies the code somewhat without sacrificing performance in any of my measurements (98% - 115% observed performance against baseline) This also removes the sysconf dependency, which caused a compile error here on FreeBSD. This also adds a --no-trailing-delimiter flag requested in #14, since this code needed to be moved anyway.
|
Fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When I run
printf "1" | huniq -d ",", it prints1,. When the input doesn't even contain the delimiter, I'd expecthuniqto not change the input. But when the input is something likeprintf "1," | huniq -d ",", then printing1,makes sense. I don't imagine it'd be that hard to fix this, but it would be really useful. A flag like--no-trailing-delimiterwould also work as well.The text was updated successfully, but these errors were encountered: