Fix describe method of JGitRepository #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use Java 8 for the project. It is required to switch off linting of the javadoc documentation to get a successful build. Furthermore the generated plugin does not have any goals. So this commit fixes the plugin plugin configuration.
The describe implmentation in JGitRepository was missing some details. With the switch to Java 8 it does not find the correct branch. This is a new implmentation of the describe function which checks all branches and should not miss any tag.
|
Sorry for the very late response. I really hate GitHub for not sending mails on newly created issues and PRs. 😞 Would you mind providing your patch as a single commit without the project changes? |
|
This has been cherry-picked into the |
|
Sorry, I've been away for a few days. I assume this is done now. Otherwise I could create another pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have included mavanagaiata 0.7.0 in a project and everything was working fine. Then we switched this project to Java 8. From this day on, mavanagaiata did not find the correct, latest, tag in the branch, but a very old one.
First I thought this is just an issue with Java 8. But after a closer look to the implementation of the describe function, I discovered that the implementation is not complete.
We use many branches in out project. The existing implementation does not follow all branches. In case one commit has two parents, it just follows one of the parents.
With this pull request a new implementation is used, which is based on the RevWalk class.