Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i"k"onli or i"c"onli #56

Closed
sormuras opened this issue Dec 13, 2019 · 7 comments
Closed

i"k"onli or i"c"onli #56

sormuras opened this issue Dec 13, 2019 · 7 comments
Assignees
Labels

Comments

@sormuras
Copy link

Here's a c:

https://github.com/aalmiray/ikonli/blob/8f497371aafd93667fa8e7f1b8e7225981e03e97/core/ikonli-core/src/main/java/module-info.java#L18

Here are ks:

  • core/ikonli-core directory
  • package org.kordamp.ikonli; in "core"
@aalmiray
Copy link
Collaborator

Oops, it should be ikonli.

@aalmiray aalmiray self-assigned this Dec 13, 2019
@aalmiray aalmiray added the Bug label Dec 13, 2019
@sormuras
Copy link
Author

It's referred to in all other module-info.java files. ;-)

@sormuras
Copy link
Author

sormuras commented Dec 13, 2019

While you're at it -- what about making the module name match the package name?

module org.kordamp.ikonli reads better.

@aalmiray
Copy link
Collaborator

Renaming modules means breaking compatibility ... oh well

aalmiray pushed a commit that referenced this issue Dec 13, 2019
@sormuras
Copy link
Author

We're all still learning...

...and I found a bunch of bugs and missing features in Bach while building ikonli. 😉

@aalmiray
Copy link
Collaborator

Yay! (?) As long as we can improve and make things better 😄 👏

@sormuras
Copy link
Author

As long as we can improve and make things better

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants