CONTRIB-6282 mod_surveypro: added one more test

kordan · May 5, 2016 · aed37bc · aed37bc
1 parent 61418dc
commit aed37bc
Show file tree

Hide file tree

Showing 37 changed files with 325 additions and 104 deletions.
diff --git a/classes/itemlist.class.php b/classes/itemlist.class.php
@@ -348,7 +348,7 @@ public function display_items_table() {
 
                         $icons = $OUTPUT->action_icon(new moodle_url('/mod/surveypro/layout_manage.php#sortindex_'.$sortindex, $paramurl),
                             new pix_icon('all', $message, 'surveypro', array('title' => $message)),
-                            null, array('id' => 'limitaccess_item_'.$item->get_sortindex(), 'title' => $message));
+                            null, array('id' => 'makereserved_item_'.$item->get_sortindex(), 'title' => $message));
                     } else {
                         $icons = $OUTPUT->pix_icon('all', $message, 'surveypro', array('title' => $message, 'class' => 'smallicon'));
                     }
@@ -361,7 +361,7 @@ public function display_items_table() {
 
                     $icons = $OUTPUT->action_icon(new moodle_url('/mod/surveypro/layout_manage.php#sortindex_'.$sortindex, $paramurl),
                         new pix_icon('limited', $message, 'surveypro', array('title' => $message)),
-                        null, array('id' => 'increaseaccess_item_'.$item->get_sortindex(), 'title' => $message));
+                        null, array('id' => 'makefree_item_'.$item->get_sortindex(), 'title' => $message));
                 }
 
                 // Second icon: insearchform vs not insearchform.
@@ -1176,6 +1176,8 @@ public function item_hide_feedback() {
      * @return void
      */
     public function item_show_execute() {
+        global $DB;
+
         // Build toshowlist.
         list($toshowlist, $sortindextoshowlist) = $this->add_parent_node(array('hidden' => 1));
 

diff --git a/field/age/tests/behat/submit_age.feature b/field/age/tests/behat/submit_age.feature
@@ -56,4 +56,4 @@ Feature: make a submission test for "age" item
     And I press "Submit"
 
     And I press "Continue to responses list"
-    Then I should see "1" submissions displayed
+    Then I should see "1" submissions
diff --git a/field/autofill/tests/behat/submit_autofill.feature b/field/autofill/tests/behat/submit_autofill.feature
@@ -48,4 +48,4 @@ Feature: make a submission test for "autofill" item
     And I press "Submit"
 
     And I press "Continue to responses list"
-    Then I should see "1" submissions displayed
+    Then I should see "1" submissions
diff --git a/field/boolean/tests/behat/submit_boolean.feature b/field/boolean/tests/behat/submit_boolean.feature
@@ -80,4 +80,4 @@ Feature: make a submission test for "boolean" item
     And I press "Submit"
 
     And I press "Continue to responses list"
-    Then I should see "1" submissions displayed
+    Then I should see "1" submissions
diff --git a/field/character/tests/behat/settings_configuration_01.feature b/field/character/tests/behat/settings_configuration_01.feature
@@ -47,15 +47,15 @@ Feature: Validate creation and submit for "character" elements using the princip
     And I press "New response"
     And I press "Submit"
     And I press "Continue to responses list"
-    Then I should see "1" submissions displayed
+    Then I should see "1" submissions
     # End of test number 1
 
     # Test number 2: Student submits a standard answer
     And I press "New response"
     And I set the field "This is a free text" to "Nice to know!"
     And I press "Submit"
     And I press "Continue to responses list"
-    Then I should see "2" submissions displayed
+    Then I should see "2" submissions
     # End of test number 2
 
   @javascript
@@ -80,7 +80,7 @@ Feature: Validate creation and submit for "character" elements using the princip
     Then I should see "Text is supposed to be longer-equal than 20 characters"
     And I press "Submit"
     And I press "Continue to responses list"
-    Then I should see "1" submissions displayed
+    Then I should see "1" submissions
     # End of test number 3
 
     # Test number 4: Student submits a standard answer
@@ -92,5 +92,5 @@ Feature: Validate creation and submit for "character" elements using the princip
     And I set the field "This is a free text" to "Ok! Now I enter a correct text."
     And I press "Submit"
     And I press "Continue to responses list"
-    Then I should see "2" submissions displayed
+    Then I should see "2" submissions
     # End of test number 4
diff --git a/field/character/tests/behat/settings_configuration_02.feature b/field/character/tests/behat/settings_configuration_02.feature
@@ -47,7 +47,7 @@ Feature: Validate creation and submit for "character" elements using the princip
     And I press "New response"
     And I press "Submit"
     And I press "Continue to responses list"
-    Then I should see "1" submissions displayed
+    Then I should see "1" submissions
     # End of test number 1
 
     # Test number 2: Student submits a standard answer
@@ -58,7 +58,7 @@ Feature: Validate creation and submit for "character" elements using the princip
     And I set the field "Write down your email" to "me@myserver.net"
     And I press "Submit"
     And I press "Continue to responses list"
-    Then I should see "2" submissions displayed
+    Then I should see "2" submissions
     # End of test number 2
 
   @javascript
@@ -83,7 +83,7 @@ Feature: Validate creation and submit for "character" elements using the princip
     Then I should see "Text is supposed to be longer-equal than 20 characters"
     And I press "Submit"
     And I press "Continue to responses list"
-    Then I should see "1" submissions displayed
+    Then I should see "1" submissions
     # End of test number 3
 
     # Test number 4: Student submits a standard answer
@@ -95,5 +95,5 @@ Feature: Validate creation and submit for "character" elements using the princip
     And I set the field "Write down your email" to "myname.myfamilyname@myserver.net"
     And I press "Submit"
     And I press "Continue to responses list"
-    Then I should see "2" submissions displayed
+    Then I should see "2" submissions
     # End of test number 4
diff --git a/field/character/tests/behat/settings_configuration_03.feature b/field/character/tests/behat/settings_configuration_03.feature
@@ -48,7 +48,7 @@ Feature: Validate creation and submit for "character" elements using the princip
     Then I should see "URL is expected here"
     And I press "Submit"
     And I press "Continue to responses list"
-    Then I should see "1" submissions displayed
+    Then I should see "1" submissions
     # End of test number 1
 
     # Test number 2: Student submits a standard answer
@@ -60,7 +60,7 @@ Feature: Validate creation and submit for "character" elements using the princip
     And I set the field "Type a web address" to "www.moodle.org"
     And I press "Submit"
     And I press "Continue to responses list"
-    Then I should see "2" submissions displayed
+    Then I should see "2" submissions
     # End of test number 2
 
   @javascript
@@ -86,7 +86,7 @@ Feature: Validate creation and submit for "character" elements using the princip
     Then I should see "Text is supposed to be longer-equal than 20 characters"
     And I press "Submit"
     And I press "Continue to responses list"
-    Then I should see "1" submissions displayed
+    Then I should see "1" submissions
     # End of test number 3
 
     # Test number 4: Student submits a standard answer
@@ -98,5 +98,5 @@ Feature: Validate creation and submit for "character" elements using the princip
     And I set the field "Type a web address" to "http://www.moodle.org"
     And I press "Submit"
     And I press "Continue to responses list"
-    Then I should see "2" submissions displayed
+    Then I should see "2" submissions
     # End of test number 4
diff --git a/field/character/tests/behat/settings_configuration_04.feature b/field/character/tests/behat/settings_configuration_04.feature
@@ -49,7 +49,7 @@ Feature: Validate creation and submit for "character" elements using the princip
     Then I should see "Text is supposed to be exactly 5 characters long; Text is supposed to match the following pattern: \"00000\""
     And I press "Submit"
     And I press "Continue to responses list"
-    Then I should see "1" submissions displayed
+    Then I should see "1" submissions
     # End of test number 1
 
     # Test number 2: Student submits a standard answer
@@ -61,7 +61,7 @@ Feature: Validate creation and submit for "character" elements using the princip
     And I set the field "Enter a zip code" to "00123"
     And I press "Submit"
     And I press "Continue to responses list"
-    Then I should see "2" submissions displayed
+    Then I should see "2" submissions
     # End of test number 2
 
   @javascript
@@ -92,5 +92,5 @@ Feature: Validate creation and submit for "character" elements using the princip
     And I set the field "Enter a zip code" to "00123"
     And I press "Submit"
     And I press "Continue to responses list"
-    Then I should see "1" submissions displayed
+    Then I should see "1" submissions
     # End of test number 3
diff --git a/field/character/tests/behat/settings_configuration_05.feature b/field/character/tests/behat/settings_configuration_05.feature
@@ -50,7 +50,7 @@ Feature: Validate creation and submit for "character" elements using the princip
     And I set the field "This is a free text" to "Nice to know!"
     And I press "Submit"
     And I press "Continue to responses list"
-    Then I should see "1" submissions displayed
+    Then I should see "1" submissions
     # End of test number 1
 
   @javascript
@@ -81,5 +81,5 @@ Feature: Validate creation and submit for "character" elements using the princip
     And I set the field "This is a free text" to "Ok! Now I enter a correct text."
     And I press "Submit"
     And I press "Continue to responses list"
-    Then I should see "1" submissions displayed
+    Then I should see "1" submissions
     # End of test number 2
diff --git a/field/character/tests/behat/settings_configuration_06.feature b/field/character/tests/behat/settings_configuration_06.feature
@@ -53,7 +53,7 @@ Feature: Validate creation and submit for "character" elements using the princip
     And I set the field "Write down your email" to "me@myserver.net"
     And I press "Submit"
     And I press "Continue to responses list"
-    Then I should see "1" submissions displayed
+    Then I should see "1" submissions
     # End of test number 1
 
   @javascript
@@ -86,5 +86,5 @@ Feature: Validate creation and submit for "character" elements using the princip
     And I set the field "Write down your email" to "myname.myfamilyname@myserver.net"
     And I press "Submit"
     And I press "Continue to responses list"
-    Then I should see "1" submissions displayed
+    Then I should see "1" submissions
     # End of test number 2
diff --git a/field/character/tests/behat/settings_configuration_07.feature b/field/character/tests/behat/settings_configuration_07.feature
@@ -53,7 +53,7 @@ Feature: Validate creation and submit for "character" elements using the princip
     And I set the field "Type a web address" to "www.moodle.org"
     And I press "Submit"
     And I press "Continue to responses list"
-    Then I should see "1" submissions displayed
+    Then I should see "1" submissions
     # End of test number 1
 
   @javascript
@@ -86,5 +86,5 @@ Feature: Validate creation and submit for "character" elements using the princip
     And I set the field "Type a web address" to "http://www.moodle.org"
     And I press "Submit"
     And I press "Continue to responses list"
-    Then I should see "1" submissions displayed
+    Then I should see "1" submissions
     # End of test number 2
diff --git a/field/checkbox/tests/behat/settings_configuration_01.feature b/field/checkbox/tests/behat/settings_configuration_01.feature
@@ -52,7 +52,7 @@ Feature: Validate creation and submit for "checkbox" elements using the principa
     And I press "New response"
     And I press "Submit"
     And I press "Continue to responses list"
-    Then I should see "1" submissions displayed
+    Then I should see "1" submissions
     # End of test number 1
 
     # Test number 2: Student submits a standard answer
@@ -62,7 +62,7 @@ Feature: Validate creation and submit for "checkbox" elements using the principa
       | id_surveypro_field_checkbox_1_3 | 1 |
     And I press "Submit"
     And I press "Continue to responses list"
-    Then I should see "2" submissions displayed
+    Then I should see "2" submissions
     # End of test number 2
 
     # Test number 3: Student chooses "No answer"
@@ -72,7 +72,7 @@ Feature: Validate creation and submit for "checkbox" elements using the principa
       | id_surveypro_field_checkbox_1_noanswer | 1 |
     And I press "Submit"
     And I press "Continue to responses list"
-    Then I should see "3" submissions displayed
+    Then I should see "3" submissions
     # End of test number 3
 
   @javascript
@@ -108,7 +108,7 @@ Feature: Validate creation and submit for "checkbox" elements using the principa
       | id_surveypro_field_checkbox_1_3 | 1 |
     And I press "Submit"
     And I press "Continue to responses list"
-    Then I should see "1" submissions displayed
+    Then I should see "1" submissions
     # End of test number 4
 
     # Test number 5: Student submits a standard answer
@@ -119,7 +119,7 @@ Feature: Validate creation and submit for "checkbox" elements using the principa
       | id_surveypro_field_checkbox_1_3 | 1 |
     And I press "Submit"
     And I press "Continue to responses list"
-    Then I should see "2" submissions displayed
+    Then I should see "2" submissions
     # End of test number 5
 
     # Test number 6: Student chooses "No answer"
@@ -130,5 +130,5 @@ Feature: Validate creation and submit for "checkbox" elements using the principa
       | id_surveypro_field_checkbox_1_noanswer | 1 |
     And I press "Submit"
     And I press "Continue to responses list"
-    Then I should see "3" submissions displayed
+    Then I should see "3" submissions
     # End of test number 6
diff --git a/field/checkbox/tests/behat/settings_configuration_02.feature b/field/checkbox/tests/behat/settings_configuration_02.feature
@@ -52,7 +52,7 @@ Feature: Validate creation and submit for "checkbox" elements using the principa
     And I press "New response"
     And I press "Submit"
     And I press "Continue to responses list"
-    Then I should see "1" submissions displayed
+    Then I should see "1" submissions
     # End of test number 1
 
     # Test number 2: Student submits a standard answer
@@ -62,7 +62,7 @@ Feature: Validate creation and submit for "checkbox" elements using the principa
       | id_surveypro_field_checkbox_1_3        | 1 |
     And I press "Submit"
     And I press "Continue to responses list"
-    Then I should see "2" submissions displayed
+    Then I should see "2" submissions
     # End of test number 2
 
     # Test number 3: Student chooses "No answer"
@@ -72,7 +72,7 @@ Feature: Validate creation and submit for "checkbox" elements using the principa
       | id_surveypro_field_checkbox_1_noanswer | 1 |
     And I press "Submit"
     And I press "Continue to responses list"
-    Then I should see "3" submissions displayed
+    Then I should see "3" submissions
     # End of test number 3
 
   @javascript
@@ -104,7 +104,7 @@ Feature: Validate creation and submit for "checkbox" elements using the principa
       | id_surveypro_field_checkbox_1_3 | 1 |
     And I press "Submit"
     And I press "Continue to responses list"
-    Then I should see "1" submissions displayed
+    Then I should see "1" submissions
     # End of test number 4
 
     # Test number 5: Student submits a standard answer
@@ -115,7 +115,7 @@ Feature: Validate creation and submit for "checkbox" elements using the principa
       | id_surveypro_field_checkbox_1_3 | 1 |
     And I press "Submit"
     And I press "Continue to responses list"
-    Then I should see "2" submissions displayed
+    Then I should see "2" submissions
     # End of test number 5
 
     # Test number 6: Student chooses "No answer"
@@ -125,5 +125,5 @@ Feature: Validate creation and submit for "checkbox" elements using the principa
       | id_surveypro_field_checkbox_1_noanswer | 1 |
     And I press "Submit"
     And I press "Continue to responses list"
-    Then I should see "3" submissions displayed
+    Then I should see "3" submissions
     # End of test number 6
diff --git a/field/checkbox/tests/behat/settings_configuration_03.feature b/field/checkbox/tests/behat/settings_configuration_03.feature
@@ -53,7 +53,7 @@ Feature: Validate creation and submit for "checkbox" elements using the principa
     Then I should not see "No answer"
     And I press "Submit"
     And I press "Continue to responses list"
-    Then I should see "1" submissions displayed
+    Then I should see "1" submissions
     # End of test number 1
 
     # Test number 2: Student submits a standard answer
@@ -63,7 +63,7 @@ Feature: Validate creation and submit for "checkbox" elements using the principa
       | id_surveypro_field_checkbox_1_3        | 1 |
     And I press "Submit"
     And I press "Continue to responses list"
-    Then I should see "2" submissions displayed
+    Then I should see "2" submissions
     # End of test number 2
 
   @javascript
@@ -100,7 +100,7 @@ Feature: Validate creation and submit for "checkbox" elements using the principa
       | id_surveypro_field_checkbox_1_2 | 1 |
     And I press "Submit"
     And I press "Continue to responses list"
-    Then I should see "1" submissions displayed
+    Then I should see "1" submissions
     # End of test number 3
 
     # Test number 4: Student submits a standard answer
@@ -111,5 +111,5 @@ Feature: Validate creation and submit for "checkbox" elements using the principa
       | id_surveypro_field_checkbox_1_3        | 1 |
     And I press "Submit"
     And I press "Continue to responses list"
-    Then I should see "2" submissions displayed
+    Then I should see "2" submissions
     # End of test number 4
diff --git a/field/checkbox/tests/behat/settings_configuration_04.feature b/field/checkbox/tests/behat/settings_configuration_04.feature
@@ -53,7 +53,7 @@ Feature: Validate creation and submit for "checkbox" elements using the principa
     Then I should not see "No answer"
     And I press "Submit"
     And I press "Continue to responses list"
-    Then I should see "1" submissions displayed
+    Then I should see "1" submissions
     # End of test number 1
 
     # Test number 2: Student submits a standard answer
@@ -63,7 +63,7 @@ Feature: Validate creation and submit for "checkbox" elements using the principa
       | id_surveypro_field_checkbox_1_3        | 1 |
     And I press "Submit"
     And I press "Continue to responses list"
-    Then I should see "2" submissions displayed
+    Then I should see "2" submissions
     # End of test number 2
 
   @javascript
@@ -96,7 +96,7 @@ Feature: Validate creation and submit for "checkbox" elements using the principa
       | id_surveypro_field_checkbox_1_0        | 1 |
     And I press "Submit"
     And I press "Continue to responses list"
-    Then I should see "1" submissions displayed
+    Then I should see "1" submissions
     # End of test number 3
 
     # Test number 4: Student submits a standard answer
@@ -106,6 +106,6 @@ Feature: Validate creation and submit for "checkbox" elements using the principa
       | id_surveypro_field_checkbox_1_0        | 1 |
     And I press "Submit"
     And I press "Continue to responses list"
-    Then I should see "2" submissions displayed
+    Then I should see "2" submissions
     # End of test number 4
 
diff --git a/field/date/tests/behat/submit_date.feature b/field/date/tests/behat/submit_date.feature
@@ -54,4 +54,4 @@ Feature: make a submission test for "date" item
     And I press "Submit"
 
     And I press "Continue to responses list"
-    Then I should see "1" submissions displayed
+    Then I should see "1" submissions