Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allows for unsetting filters #14

Merged
merged 1 commit into from
Apr 17, 2022
Merged

Allows for unsetting filters #14

merged 1 commit into from
Apr 17, 2022

Conversation

ToxicMushroom
Copy link
Contributor

  • adds unsetX functions to the Filter implementation
  • make all Effects implement the Filter interface

e.g

musicPlayer.applyFilters {
    unsetKaraoke()
}

@DRSchlaubi DRSchlaubi merged commit 65bc0ac into kordlib:main Apr 17, 2022
@ToxicMushroom ToxicMushroom deleted the filters branch April 18, 2022 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ToxicMushroom @DRSchlaubi