Fix MessageStickerType constructor initialization deadlock #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukellmann
approved these changes
Aug 15, 2022
I already considered this, see here :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of initializing the set during class load, the set will be created when calling the
valueslist.Fixes #669
Other Kord classes also handles
valueslists in the same manner (Image,DiscordChannel,DiscordMessage, etc), so I've decided to keep it in the same way.However, Lost and Lukellmann pointed out that using
by lazyalso fixes the issue, and I have tested it and it also does work, so maybe this is something to keep in mind for the future to avoid unnecessary set allocations.